-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): bugs in Custom SQL editor in filter popover #12278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@kgabryje there is a minor change to current behavior that requires updating a unit test. Check the frontend build error (I think it's fine to update the test): |
Codecov Report
@@ Coverage Diff @@
## master #12278 +/- ##
==========================================
- Coverage 67.17% 62.81% -4.37%
==========================================
Files 1002 1002
Lines 49231 49275 +44
Branches 5000 5006 +6
==========================================
- Hits 33073 30950 -2123
- Misses 16035 18123 +2088
- Partials 123 202 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Fix Save button disabled until clause is switched * Fix 'undefined undefined' when sql query is empty * fix test Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
* Fix Save button disabled until clause is switched * Fix 'undefined undefined' when sql query is empty * fix test Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit e660723)
* Fix Save button disabled until clause is switched * Fix 'undefined undefined' when sql query is empty * fix test Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
SUMMARY
Fixes 2 bugs:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
CC: @villebro @junlincc @rusackas