Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): bugs in Custom SQL editor in filter popover #12278

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jan 5, 2021

SUMMARY

Fixes 2 bugs:

  • 'undefined undefined' when SQL query is empty and we switch to another clause
  • Save button inactive until clause is switched

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

CC: @villebro @junlincc @rusackas

@junlincc junlincc requested review from junlincc and rusackas January 5, 2021 16:02
@junlincc junlincc added #bug:blocking! Blocking issues with high priority rush! Requires immediate attention labels Jan 5, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kgabryje kgabryje closed this Jan 5, 2021
@kgabryje kgabryje reopened this Jan 5, 2021
@mistercrunch mistercrunch reopened this Jan 5, 2021
@villebro
Copy link
Member

villebro commented Jan 6, 2021

@kgabryje there is a minor change to current behavior that requires updating a unit test. Check the frontend build error (I think it's fine to update the test):
image

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #12278 (e114b45) into master (d4a854e) will decrease coverage by 4.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12278      +/-   ##
==========================================
- Coverage   67.17%   62.81%   -4.37%     
==========================================
  Files        1002     1002              
  Lines       49231    49275      +44     
  Branches     5000     5006       +6     
==========================================
- Hits        33073    30950    -2123     
- Misses      16035    18123    +2088     
- Partials      123      202      +79     
Flag Coverage Δ
cypress ?
javascript 61.22% <100.00%> (-0.04%) ⬇️
python 63.83% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/AdhocFilterEditPopoverSqlTabContent.jsx 65.51% <ø> (-1.15%) ⬇️
superset-frontend/src/explore/AdhocFilter.js 93.24% <100.00%> (-4.10%) ⬇️
superset-frontend/src/explore/exploreUtils.js 58.59% <100.00%> (-8.30%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 217 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a854e...e114b45. Read the comment docs.

@villebro villebro changed the title fix: Bugs in Custom SQL editor in filter popover fix(explore): bugs in Custom SQL editor in filter popover Jan 6, 2021
@villebro villebro merged commit e660723 into apache:master Jan 6, 2021
villebro added a commit to preset-io/superset that referenced this pull request Jan 7, 2021
* Fix Save button disabled until clause is switched

* Fix 'undefined undefined' when sql query is empty

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
henryyeh pushed a commit to preset-io/superset that referenced this pull request Jan 7, 2021
* Fix Save button disabled until clause is switched

* Fix 'undefined undefined' when sql query is empty

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
(cherry picked from commit e660723)
villebro added a commit to preset-io/superset that referenced this pull request Jan 7, 2021
* Fix Save button disabled until clause is switched

* Fix 'undefined undefined' when sql query is empty

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
@junlincc junlincc added the explore:filter Related to filters in Explore label Jan 8, 2021
@junlincc junlincc removed #bug:blocking! Blocking issues with high priority rush! Requires immediate attention labels Jan 25, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:filter Related to filters in Explore size/M 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants