Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump superset-ui deps #12280

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jan 5, 2021

SUMMARY

Bump superset-ui deps in order to fix #12266 . Actual work done in apache-superset/superset-ui#886.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

@junlincc junlincc added #bug:blocking! Blocking issues with high priority rush! Requires immediate attention labels Jan 5, 2021
@junlincc
Copy link
Member

junlincc commented Jan 5, 2021

rushing this PR, as it associate with the custom sql filter issue.

@kgabryje kgabryje closed this Jan 5, 2021
@kgabryje kgabryje reopened this Jan 5, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I restared CI, let's hope it goes through soon.

@ktmud ktmud closed this Jan 5, 2021
@ktmud ktmud reopened this Jan 5, 2021
@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #12280 (3270eef) into master (1b908ab) will decrease coverage by 7.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12280      +/-   ##
==========================================
- Coverage   58.75%   51.38%   -7.37%     
==========================================
  Files         886      466     -420     
  Lines       43553    16768   -26785     
  Branches     3448     4304     +856     
==========================================
- Hits        25590     8617   -16973     
+ Misses      17963     8151    -9812     
Flag Coverage Δ
cypress 51.38% <ø> (+4.47%) ⬆️
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/commands/delete.py
...rations/versions/e46f2d27a08e_materialize_perms.py
...versions/0b1f1ab473c0_add_extra_column_to_query.py
superset/views/dynamic_plugins.py
superset/security/manager.py
superset/commands/importers/v1/utils.py
...ns/978245563a02_migrate_iframe_to_dash_markdown.py
...versions/40f16acf1ba7_security_converge_reports.py
superset/migrations/versions/d39b1e37131d_.py
superset/db_engine_specs/mysql.py
... and 646 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b908ab...3270eef. Read the comment docs.

@ktmud ktmud force-pushed the fix/add-undefined branch from e49fc57 to 3270eef Compare January 6, 2021 00:37
@mistercrunch mistercrunch merged commit d0668fa into apache:master Jan 6, 2021
villebro pushed a commit to preset-io/superset that referenced this pull request Jan 7, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request Jan 7, 2021
(cherry picked from commit d0668fa)
@junlincc junlincc added viz:explore:viewdata explore:control Related to the controls panel of Explore and removed viz:explore:viewdata labels Jan 8, 2021
@junlincc junlincc removed #bug:blocking! Blocking issues with high priority rush! Requires immediate attention labels Jan 25, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:control Related to the controls panel of Explore size/M 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[explore]filter custom SQL editor is broken, adding undefined clause
6 participants