Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cypress): ignore unrelated ResizeObserver client errors #12297

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

robdiciuccio
Copy link
Member

SUMMARY

The majority of flaky Cypress tests are being caused by an uncaught JS error: ResizeObserver loop limit exceeded. All indications are that this error can be safely ignored, and should not fail Cypress tests.

Related Cypress docs: https://docs.cypress.io/api/events/catalog-of-events.html#Uncaught-Exceptions

Screen Shot 2021-01-05 at 5 02 27 PM

TEST PLAN

Ensure successful Cypress test suite run.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #12297 (91d52ed) into master (553b440) will decrease coverage by 7.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12297      +/-   ##
==========================================
- Coverage   67.18%   59.39%   -7.80%     
==========================================
  Files        1002      951      -51     
  Lines       49231    46598    -2633     
  Branches     5000     4304     -696     
==========================================
- Hits        33074    27675    -5399     
- Misses      16034    18923    +2889     
+ Partials      123        0     -123     
Flag Coverage Δ
cypress 51.38% <ø> (-0.03%) ⬇️
javascript ?
python 63.88% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 11.76% <0.00%> (-88.24%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
superset-frontend/src/components/IconTooltip.tsx 13.33% <0.00%> (-86.67%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...end/src/SqlLab/components/ExploreResultsButton.jsx 8.00% <0.00%> (-84.00%) ⬇️
...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx 14.70% <0.00%> (-82.97%) ⬇️
... and 387 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 553b440...91d52ed. Read the comment docs.

@robdiciuccio robdiciuccio merged commit b4f6d35 into apache:master Jan 6, 2021
@robdiciuccio robdiciuccio deleted the rd/cypress-resize-observer branch January 6, 2021 01:44
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants