Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove additional incubator references #12336

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

amitmiran137
Copy link
Member

@amitmiran137 amitmiran137 commented Jan 7, 2021

SUMMARY

remove incubator.png from the main docs page
remove additional comments and docs references

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
image
after:
image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #12336 (6cdc5a4) into master (076c31d) will decrease coverage by 3.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12336      +/-   ##
==========================================
- Coverage   66.60%   62.98%   -3.62%     
==========================================
  Files        1002     1002              
  Lines       49330    49316      -14     
  Branches     5020     5020              
==========================================
- Hits        32855    31062    -1793     
- Misses      16333    18050    +1717     
- Partials      142      204      +62     
Flag Coverage Δ
cypress ?
javascript 61.17% <ø> (ø)
python 64.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...versions/f9a30386bd74_cleanup_time_grainularity.py 0.00% <ø> (ø)
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <0.00%> (-100.00%) ⬇️
...tend/src/dashboard/containers/DashboardBuilder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...c/visualizations/FilterBox/FilterBoxChartPlugin.js 0.00% <0.00%> (-100.00%) ⬇️
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076c31d...378d3e5. Read the comment docs.

@willbarrett willbarrett merged commit 4cf3f99 into apache:master Jan 11, 2021
amitmiran137 added a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
* chore: remove additional incubator references
remove incubator.png from the main docs page

* fix: improve text for contributing-page.mdx

* fix: lint no-unused-vars
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants