Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): explore window replace wrong standalone slice url #12359

Merged
merged 1 commit into from
Jan 9, 2021

Conversation

duynguyenhoang
Copy link
Contributor

@duynguyenhoang duynguyenhoang commented Jan 8, 2021

SUMMARY

Fix the issue with standalone slice in explore component. When it replace browser url, it doesn't consider standalone parameter

TEST PLAN

ADDITIONAL INFORMATION

@duynguyenhoang duynguyenhoang changed the title Fix explore replace wrong standalone slice url fix: explore window replace wrong standalone slice url Jan 8, 2021
@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #12359 (722a79e) into master (fd15dff) will decrease coverage by 2.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12359      +/-   ##
==========================================
- Coverage   66.36%   63.65%   -2.72%     
==========================================
  Files        1014      485     -529     
  Lines       49513    29888   -19625     
  Branches     5066        0    -5066     
==========================================
- Hits        32861    19025   -13836     
+ Misses      16508    10863    -5645     
+ Partials      144        0     -144     
Flag Coverage Δ
cypress ?
javascript ?
python 63.65% <ø> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.62%) ⬇️
superset/db_engine_specs/presto.py 70.56% <0.00%> (-12.13%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 96.51% <0.00%> (-2.33%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 88.04% <0.00%> (-0.82%) ⬇️
superset/connectors/sqla/models.py 91.37% <0.00%> (-0.14%) ⬇️
...rontend/src/dashboard/containers/DashboardGrid.jsx
...src/explore/components/AdhocMetricStaticOption.jsx
... and 526 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd15dff...d793bfd. Read the comment docs.

@duynguyenhoang duynguyenhoang force-pushed the bug/fix_standlone_url_explore branch from a65ef77 to 722a79e Compare January 8, 2021 20:30
@duynguyenhoang duynguyenhoang force-pushed the bug/fix_standlone_url_explore branch from 722a79e to d793bfd Compare January 8, 2021 20:33
@junlincc junlincc requested a review from ktmud January 8, 2021 21:40
@ktmud ktmud merged commit 99de8a4 into apache:master Jan 9, 2021
@junlincc junlincc changed the title fix: explore window replace wrong standalone slice url fix(explore): explore window replace wrong standalone slice url Jan 11, 2021
@duynguyenhoang duynguyenhoang deleted the bug/fix_standlone_url_explore branch January 20, 2021 05:35
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants