Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Don't run a query on every change in chart controls #12361

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jan 8, 2021

SUMMARY

Closes #12207
Closes #12317

As you can see on video below, no request is triggered until user click Run query.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: see linked issues
After:
https://user-images.githubusercontent.com/15073128/104059464-b4609d00-51f5-11eb-95c5-0c3b9f368f23.mov

TEST PLAN

ADDITIONAL INFORMATION

CC: @junlincc @villebro @ktmud

@junlincc junlincc added rush! Requires immediate attention #bug:blocking! Blocking issues with high priority labels Jan 8, 2021
@junlincc junlincc requested review from junlincc and rusackas January 8, 2021 20:25
@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #12361 (48145be) into master (76b06b2) will decrease coverage by 4.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12361      +/-   ##
==========================================
- Coverage   66.94%   62.82%   -4.12%     
==========================================
  Files        1014     1014              
  Lines       49516    49500      -16     
  Branches     5068     5066       -2     
==========================================
- Hits        33147    31097    -2050     
- Misses      16239    18194    +1955     
- Partials      130      209      +79     
Flag Coverage Δ
cypress ?
javascript 60.69% <0.00%> (-0.01%) ⬇️
python 64.21% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/ExploreViewContainer.jsx 2.58% <0.00%> (-77.29%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/filters/components/Select/types.ts 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.js 0.00% <0.00%> (-100.00%) ⬇️
... and 193 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b06b2...48145be. Read the comment docs.

@junlincc junlincc requested a review from ktmud January 8, 2021 20:52
Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktmud ktmud merged commit 1d27899 into apache:master Jan 8, 2021
@junlincc
Copy link
Member

junlincc commented Jan 8, 2021

tested manually, LGTM. thanks for merging!! @ktmud

@junlincc junlincc added the explore:control Related to the controls panel of Explore label Jan 8, 2021
@junlincc junlincc changed the title fix: Don't run a query on every change in chart controls fix(explore): Don't run a query on every change in chart controls Jan 11, 2021
@junlincc junlincc removed #bug:blocking! Blocking issues with high priority rush! Requires immediate attention labels Jan 25, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:control Related to the controls panel of Explore size/XS 🚢 1.0.0
Projects
None yet
5 participants