Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Filter popover is covered by data table on Explore #12377

Merged
merged 1 commit into from
Jan 9, 2021

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jan 9, 2021

SUMMARY

Closes #12373

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: see linked issue
After:
image

TEST PLAN

ADDITIONAL INFORMATION

CC: @junlincc @rusackas

@codecov-io
Copy link

codecov-io commented Jan 9, 2021

Codecov Report

Merging #12377 (da79b43) into master (1250426) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12377   +/-   ##
=======================================
  Coverage   66.87%   66.88%           
=======================================
  Files        1014     1014           
  Lines       49508    49508           
  Branches     5063     5063           
=======================================
+ Hits        33110    33112    +2     
+ Misses      16268    16266    -2     
  Partials      130      130           
Flag Coverage Δ
cypress 50.93% <ø> (+<0.01%) ⬆️
javascript 60.70% <ø> (ø)
python 64.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/explore/components/AdhocFilterPopoverTrigger.tsx 69.23% <ø> (ø)
...ntend/src/dashboard/components/PropertiesModal.jsx 83.03% <0.00%> (ø)
...rset-frontend/src/explore/components/SaveModal.tsx 91.76% <0.00%> (+1.17%) ⬆️
...set-frontend/src/dashboard/util/getDropPosition.js 93.65% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1250426...da79b43. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM and tested, no unexpected side effects identified

Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezgif-3-58b3382be7f2

Screen Shot 2021-01-09 at 12 41 57 AM

Screen Shot 2021-01-09 at 12 43 42 AM

tested on nvd3, table, deck.gl, echarts. no longer seeing issues i described in [Explore]Filter popover is covered by the Data section

@ktmud ktmud merged commit 6a3103f into apache:master Jan 9, 2021
@junlincc junlincc changed the title fix: Filter popover is covered by data table on Explore fix(explore): Filter popover is covered by data table on Explore Jan 9, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Explore]Filter popover is covered by the Data section
6 participants