Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): adhoc metric label and control value not consistent #12381

Merged
merged 3 commits into from
Jan 9, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jan 9, 2021

SUMMARY

fix #12367
Closes #12367

  • adhoc metric control must reset state when close Popover

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

add e2e in future

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added the explore:control Related to the controls panel of Explore label Jan 9, 2021
@codecov-io
Copy link

codecov-io commented Jan 9, 2021

Codecov Report

Merging #12381 (d38c349) into master (1250426) will decrease coverage by 3.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12381      +/-   ##
==========================================
- Coverage   66.87%   63.65%   -3.23%     
==========================================
  Files        1014      485     -529     
  Lines       49508    29888   -19620     
  Branches     5063        0    -5063     
==========================================
- Hits        33110    19025   -14085     
+ Misses      16268    10863    -5405     
+ Partials      130        0     -130     
Flag Coverage Δ
cypress ?
javascript ?
python 63.65% <ø> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.62%) ⬇️
superset/db_engine_specs/presto.py 70.56% <0.00%> (-12.78%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 96.51% <0.00%> (-2.33%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 88.04% <0.00%> (-0.82%) ⬇️
superset/connectors/sqla/models.py 91.37% <0.00%> (-0.14%) ⬇️
superset-frontend/src/utils/cacheWrapper.ts
...src/dashboard/components/DeleteComponentButton.jsx
... and 526 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1250426...d38c349. Read the comment docs.

Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezgif-3-a8dc7a5057fb

thanks for the PR! input should be cleared when mouse away as well.

@junlincc
Copy link
Member

junlincc commented Jan 9, 2021

ezgif-7-4f780d702728

confirm this has been an issue for a looong time, not introduce by any recent refactoring work
@zhaoyongjie let's not worry about the mouse away for now

cc: @ktmud @kgabryje @villebro @graceguo-supercat

@zhaoyongjie
Copy link
Member Author

zhaoyongjie commented Jan 9, 2021

@junlincc
The Popover hide when the mouse leaves and click, Unable to change the state of a child component, this is old behavior.

refactor the adhoc metrics in the future, i will fix it again

@zhaoyongjie zhaoyongjie merged commit 64b4977 into apache:master Jan 9, 2021
@villebro
Copy link
Member

villebro commented Jan 9, 2021

Let's rather open a new fix PR if possible @zhaoyongjie

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie deleted the fix_adhoc_metric branch January 16, 2021 04:17
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:control Related to the controls panel of Explore size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Explore] Metric control displayed value is not consistent with current query
6 participants