-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): adhoc metric label and control value not consistent #12381
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12381 +/- ##
==========================================
- Coverage 66.87% 63.65% -3.23%
==========================================
Files 1014 485 -529
Lines 49508 29888 -19620
Branches 5063 0 -5063
==========================================
- Hits 33110 19025 -14085
+ Misses 16268 10863 -5405
+ Partials 130 0 -130
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirm this has been an issue for a looong time, not introduce by any recent refactoring work |
@junlincc refactor the adhoc metrics in the future, i will fix it again |
Let's rather open a new fix PR if possible @zhaoyongjie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
fix #12367
Closes #12367
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
add e2e in future
ADDITIONAL INFORMATION