-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): flaky Change dataset modal #12390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12390 +/- ##
==========================================
- Coverage 66.88% 66.88% -0.01%
==========================================
Files 1014 1014
Lines 49526 49527 +1
Branches 5073 5073
==========================================
Hits 33124 33124
- Misses 16272 16273 +1
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@geido thanks for the quick fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geido let's open a new PR to implement the enhancement on search! many thanks for fixing this P0 issue!!!
FYI @eschutho @betodealmeida this issue is likely caused by #12006
SUMMARY
Closes #12389
The debounce effect was retriggered all the time causing the fetch to be called in an infinite loop.
BEFORE
AFTER
TEST PLAN
ADDITIONAL INFORMATION