Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(native-filters): incorrect queriesData state #12409

Merged
merged 1 commit into from
Jan 12, 2021
Merged

fix(native-filters): incorrect queriesData state #12409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions superset-frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion superset-frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@
"@superset-ui/plugin-chart-echarts": "^0.16.4",
"@superset-ui/plugin-chart-table": "^0.16.4",
"@superset-ui/plugin-chart-word-cloud": "^0.16.4",
"@superset-ui/plugin-filter-antd": "^0.16.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we moved it to the current repository, so better take from here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow - That's why I removed it

Copy link
Contributor

@simcha90 simcha90 Jan 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah got it not correct, it's ok 👍

"@superset-ui/preset-chart-xy": "^0.16.4",
"@vx/responsive": "^0.0.195",
"abortcontroller-polyfill": "^1.1.9",
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ const FilterValue: React.FC<FilterProps> = ({
height={20}
width={220}
formData={getFormData()}
queriesData={[state]}
queriesData={state}
chartType="filter_select"
hooks={{ setExtraFormData }}
/>
Expand Down