chore(chart): Save modal select placeholder value #12413
Conversation
|
🏷️ viz:explore:ui |
| @@ -29,7 +29,7 @@ import { connect } from 'react-redux'; | |||
|
|
|||
| // Session storage key for recent dashboard | |||
| const SK_DASHBOARD_ID = 'save_chart_recent_dashboard'; | |||
| const SELECT_PLACEHOLDER = t('**Select** a dashboard OR **create** a new one'); | |||
| const SELECT_PLACEHOLDER = t('Select dashboard'); | |||
There was a problem hiding this comment.
Can we keep the original copy as I don't think we've added the functionality to create a dashboard in the dropdown yet.
https://projects.invisionapp.com/share/V5VH03AHBER#/screens/399817652
cc @mihir174
For context, #10355 added this copy and there is a discussion on why this is still not optimal.
There was a problem hiding this comment.
@ktmud but the original text is referring to dashboard creation through save modal?
There was a problem hiding this comment.
Yes and I think we decided to allow users to do that since that's what in the original modal. Have we removed that functionality?
There was a problem hiding this comment.
It is possible to create a dashboard through this modal and I guess text should claim that creation is possible.
|
I have a behavior where when I add new chart and try to save it is automatically selected first dashboard from list: Nagranie.z.ekranu.2021-01-11.o.20.57.37.movI guess it should not be chosen by default to avoid mistakes. In previous releases it was not proposed. |
Codecov Report
@@ Coverage Diff @@
## master #12413 +/- ##
==========================================
- Coverage 66.88% 66.76% -0.13%
==========================================
Files 1014 1015 +1
Lines 49513 49644 +131
Branches 5077 4972 -105
==========================================
+ Hits 33118 33144 +26
- Misses 16264 16377 +113
+ Partials 131 123 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
When users come from "View chart in Explore" on the dashboard page, the origin dashboard should be selected (so they can click on "Save & Go to Dashboard"). When users edit an existing chart from the Chart List page, the dashboard should not be selected. (I think this is the current behavior and it's correct.) |
|
thanks for the context @ktmud Here's a common UI pattern I've seen in many products for this scenario -
|
|
Dashboards should now be selected properly and I changed the placeholder text |
There was a problem hiding this comment.
LGTM! thanks for the PR! @villebro @zhaoyongjie ready for code review. @ktmud take another look?
Explore save modal deserves a much bigger redesign. I can easily name a handful of UX issues.😞 Nothing critical, we can wait.
mistercrunch
added
🏷️ bot
SUMMARY
Fix SaveModal dashboard select placeholder value and clear button.
#12366
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
Expected result: Under ADD TO DASHBOARD label, select dropdown should have a placeholder text with no clear button. If the value is selected, the value should be displayed instead of placeholder and clear button should appear.
ADDITIONAL INFORMATION