Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong column name 'Gender' #12506

Closed
wants to merge 1 commit into from
Closed

fix: wrong column name 'Gender' #12506

wants to merge 1 commit into from

Conversation

zuzhi
Copy link

@zuzhi zuzhi commented Jan 13, 2021

SUMMARY

Closes #12505

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TEST PLAN

  1. Run 'superset load_example' again
  2. Should see no errors in this dashboard

ADDITIONAL INFORMATION

@codecov-io
Copy link

codecov-io commented Jan 13, 2021

Codecov Report

Merging #12506 (e3c458c) into master (52ba82f) will decrease coverage by 7.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12506      +/-   ##
==========================================
- Coverage   66.83%   59.17%   -7.66%     
==========================================
  Files        1015      959      -56     
  Lines       49594    46832    -2762     
  Branches     5081     4344     -737     
==========================================
- Hits        33144    27713    -5431     
- Misses      16320    19119    +2799     
+ Partials      130        0     -130     
Flag Coverage Δ
cypress 50.94% <ø> (+<0.01%) ⬆️
javascript ?
python 63.80% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 11.76% <0.00%> (-88.24%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
superset-frontend/src/components/IconTooltip.tsx 13.33% <0.00%> (-86.67%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...end/src/SqlLab/components/ExploreResultsButton.jsx 8.00% <0.00%> (-84.00%) ⬇️
...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx 14.70% <0.00%> (-82.97%) ⬇️
... and 399 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ba82f...e3c458c. Read the comment docs.

@junlincc
Copy link
Member

junlincc commented Jan 15, 2021

thank you so much for your contribution🙏
may have to leave this open(or close it), in favor of #12530

cc @betodealmeida

@zuzhi
Copy link
Author

zuzhi commented Jan 15, 2021

@junlincc It's ok. Glad to see it's fixed.

@zuzhi zuzhi closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] FCC New Coder Survey 2018, Error: Columns missing in datasource: ['Gender']
3 participants