Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lowercase all columns in examples #12530

Merged
merged 1 commit into from
Jan 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ params:
donut: true
granularity_sqla: time_start
groupby:
- Ethnic Minority
- ethnic_minority
innerRadius: 44
label_line: true
labels_outside: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ params:
datasource: 42__table
granularity_sqla: time_start
groupby:
- Developer Type
- developer_type
metrics:
- count
order_by_cols: []
Expand Down
2 changes: 1 addition & 1 deletion superset/examples/configs/charts/Commute_Time.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ params:
isNew: false
operator: ==
sqlExpression: null
subject: Developer Type
subject: developer_type
- clause: WHERE
comparator: 'NULL'
expressionType: SIMPLE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ params:
isNew: false
operator: ==
sqlExpression: null
subject: Developer Type
subject: developer_type
datasource: 42__table
granularity_sqla: time_start
header_font_size: 0.4
Expand Down
4 changes: 2 additions & 2 deletions superset/examples/configs/charts/Ethnic_Minority__Gender.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ params:
isNew: false
operator: '!='
sqlExpression: null
subject: Ethnic Minority
subject: ethnic_minority
- clause: WHERE
comparator: 'NULL'
expressionType: SIMPLE
Expand All @@ -40,7 +40,7 @@ params:
datasource: 42__table
granularity_sqla: time_start
groupby:
- Ethnic Minority
- ethnic_minority
- gender
label_colors: {}
metric: count
Expand Down
9 changes: 7 additions & 2 deletions superset/examples/configs/charts/Filter_Segments.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,32 +23,37 @@ params:
filter_configs:
- asc: true
clearable: true
column: Ethnic Minority
column: ethnic_minority
key: -xNBqpfQo
label: Ethnic Minority
multiple: true
searchAllOptions: false
- asc: true
clearable: true
column: gender
key: 19VeBGTKf
label: Gender
multiple: true
searchAllOptions: false
- asc: true
clearable: true
column: Developer Type
column: developer_type
key: OWTb4s69T
label: Developer Type
multiple: true
searchAllOptions: false
- asc: true
clearable: true
column: lang_at_home
key: Fn-YClyhb
label: Language at Home
multiple: true
searchAllOptions: false
- asc: true
clearable: true
column: country_live
key: 2fNskRCLJ
label: Country live
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, do you want to capitalize Live?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, but TBH we might need to come up with something better. @srinify what should be the label here? "Country currently living on"?

multiple: true
searchAllOptions: false
granularity_sqla: time_start
Expand Down
7 changes: 4 additions & 3 deletions superset/examples/configs/charts/Filtering_Vaccines.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,23 @@ params:
filter_configs:
- asc: true
clearable: true
column: Country_Name
column: country_name
key: D00hRxPLE
label: Country
multiple: true
searchAllOptions: false
- asc: true
clearable: true
column: Product_Category
column: product_category
key: jJ7x2cuIc
label: Vaccine Approach
multiple: true
searchAllOptions: false
- asc: true
clearable: true
column: Clinical Stage
column: clinical_stage
key: EgGwwAUU6
label: Clinical Stage
multiple: true
searchAllOptions: false
queryFields: {}
Expand Down
4 changes: 2 additions & 2 deletions superset/examples/configs/charts/First_Time_Developer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ params:
isNew: false
operator: ==
sqlExpression: null
subject: Developer Type
subject: developer_type
color_scheme: supersetColors
datasource: 42__table
donut: true
granularity_sqla: time_start
groupby:
- First Time Developer
- first_time_developer
innerRadius: 43
labels_outside: true
metric: count
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ params:
isNew: false
operator: '!='
sqlExpression: null
subject: First Time Developer
subject: first_time_developer
- clause: WHERE
comparator: 'NULL'
expressionType: SIMPLE
Expand All @@ -49,7 +49,7 @@ params:
datasource: 42__table
granularity_sqla: time_start
groupby:
- First Time Developer
- first_time_developer
- communite_time
label_colors: {}
metric: count
Expand Down
20 changes: 10 additions & 10 deletions superset/examples/configs/charts/Games.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,22 @@ viz_type: table
params:
adhoc_filters: []
all_columns:
- Name
- Global_Sales
- Platform
- Genre
- Publisher
- Year
- name
- global_sales
- platform
- genre
- publisher
- year
color_pn: false
datasource: 21__table
granularity_sqla: Year
granularity_sqla: year
groupby:
- Name
- name
include_search: true
metrics:
- aggregate: SUM
column:
column_name: Global_Sales
column_name: global_sales
description: null
expression: null
filterable: true
Expand All @@ -52,7 +52,7 @@ params:
optionName: metric_pkpvgdsf70d_pnqv77v0x2p
sqlExpression: null
order_by_cols:
- '["Global_Sales", false]'
- '["global_sales", false]'
order_desc: true
page_length: '15'
percent_metrics: []
Expand Down
6 changes: 3 additions & 3 deletions superset/examples/configs/charts/Games_per_Genre.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ params:
adhoc_filters: []
color_scheme: supersetColors
datasource: 1559__table
granularity_sqla: Year
granularity_sqla: year
groupby:
- Genre
- genre
label_colors:
'0': '#1FA8C9'
'1': '#454E7C'
Expand Down Expand Up @@ -89,7 +89,7 @@ params:
- exclusive
treemap_ratio: 1.618033988749895
url_params:
preselect_filters: '{"1389": {"Platform": ["PS", "PS2", "PS3", "PS4"], "Genre":
preselect_filters: '{"1389": {"platform": ["PS", "PS2", "PS3", "PS4"], "genre":
null, "__time_range": "No filter"}}'
viz_type: treemap
cache_timeout: null
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ params:
comparison_type: values
contribution: false
datasource: 21__table
granularity_sqla: Year
granularity_sqla: year
groupby:
- Genre
- genre
label_colors:
'0': '#1FA8C9'
'1': '#454E7C'
Expand Down Expand Up @@ -101,7 +101,7 @@ params:
- inclusive
- exclusive
url_params:
preselect_filters: '{"1389": {"Platform": ["PS", "PS2", "PS3", "PS4"], "Genre":
preselect_filters: '{"1389": {"platform": ["PS", "PS2", "PS3", "PS4"], "genre":
null, "__time_range": "No filter"}}'
viz_type: line
x_axis_format: smart_date
Expand Down
2 changes: 1 addition & 1 deletion superset/examples/configs/charts/Gender.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ params:
donut: true
granularity_sqla: time_start
groupby:
- Gender
- gender
innerRadius: 44
label_line: true
labels_outside: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ params:
isNew: false
operator: ==
sqlExpression: null
subject: Developer Type
subject: developer_type
- clause: WHERE
comparator: '200000'
expressionType: SIMPLE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ params:
isNew: false
operator: ==
sqlExpression: null
subject: Developer Type
subject: developer_type
- clause: WHERE
comparator: '100000'
expressionType: SIMPLE
Expand Down
8 changes: 4 additions & 4 deletions superset/examples/configs/charts/Most_Dominant_Platforms.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,20 @@ params:
isNew: false
operator: <=
sqlExpression: null
subject: Rank
subject: rank
color_scheme: supersetColors
datasource: 21__table
donut: true
granularity_sqla: Year
granularity_sqla: year
groupby:
- Publisher
- publisher
innerRadius: 45
label_line: true
labels_outside: true
metric:
aggregate: SUM
column:
column_name: Global_Sales
column_name: global_sales
description: null
expression: null
filterable: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ slice_name: Number of Deals (for each Combination)
viz_type: heatmap
params:
adhoc_filters: []
all_columns_x: DealSize
all_columns_y: ProductLine
all_columns_x: deal_size
all_columns_y: product_line
bottom_margin: 100
canvas_image_rendering: pixelated
datasource: 23__table
granularity_sqla: OrderDate
granularity_sqla: order_date
left_margin: 75
linear_color_scheme: schemePuBuGn
metric: count
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ params:
adhoc_filters: []
color_scheme: supersetColors
datasource: 21__table
granularity_sqla: Year
granularity_sqla: year
groupby:
- Platform
- platform
label_colors:
'2600': '#D1C6BC'
3DO: '#A38F79'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@ params:
color_scheme: supersetColors
datasource: 23__table
donut: true
granularity_sqla: OrderDate
granularity_sqla: order_date
groupby:
- ProductLine
- product_line
innerRadius: 41
label_line: true
labels_outside: true
metric:
aggregate: SUM
column:
column_name: Sales
column_name: sales
description: null
expression: null
filterable: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ slice_name: Popular Genres Across Platforms
viz_type: heatmap
params:
adhoc_filters: []
all_columns_x: Platform
all_columns_y: Genre
all_columns_x: platform
all_columns_y: genre
bottom_margin: auto
canvas_image_rendering: pixelated
datasource: 64__table
granularity_sqla: Year
granularity_sqla: year
left_margin: auto
linear_color_scheme: blue_white_yellow
metric: count
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ params:
comparison_type: values
contribution: true
datasource: 23__table
granularity_sqla: OrderDate
granularity_sqla: order_date
groupby:
- ProductLine
- product_line
label_colors: {}
line_interpolation: linear
metrics:
- aggregate: SUM
column:
column_name: Sales
column_name: sales
description: null
expression: null
filterable: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@ viz_type: table
params:
adhoc_filters: []
all_columns:
- Rank
- Name
- Global_Sales
- Platform
- Genre
- Publisher
- Year
- rank
- name
- global_sales
- platform
- genre
- publisher
- year
color_pn: false
datasource: 21__table
granularity_sqla: Year
granularity_sqla: year
groupby: []
metrics:
- count
Expand Down
Loading