-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add docs for GLOBAL_ASYNC_QUERIES (SIP-39) #12573
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12573 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 1015 1015
Lines 49633 49633
Branches 4839 4839
=======================================
+ Hits 33133 33134 +1
+ Misses 16377 16376 -1
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
we cut rc4 and kicked off the vote on Friday night. Async query docs update can go in the patch release, right? as it's not directly related to any urgent issues. given that we have Monday off, and announcing 1.0 on Thursday, we won't have enough time to the get this in. have to change label to v.1.0.1. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If there are any Celery/Redis specific configs that have been found to work well it could also be nice to add those to the documentation (see e.g. #11499 (comment) )
SUMMARY
Adds documentation for
GLOBAL_ASYNC_QUERIES
feature, including all configuration settings. See #11499 for related code.ADDITIONAL INFORMATION