fix(dashboard): top dropdown indicator in tab moved closer to the bottom edge

[kkucharc]

SUMMARY

Really small fix in drag and drop indicator in tabs area: it is moved a few pixels down to be below the tab name area.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

1. Go to dashboards
2. Choose a dashboard (can be Tabbed Dashboard)
3. Go to edit mode
4. Add chart (or markdown) to the tabs area

I tested with native filters enabled and disabled.

ADDITIONAL INFORMATION

Connected to: #12486

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[kkucharc]

@ktmud @junlincc tell me if it looks fine for you :)

[codecov-io]

Codecov Report

Merging #12658 (0c183c6) into master (f2b8029) will decrease coverage by 3.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12658      +/-   ##
==========================================
- Coverage   66.93%   63.83%   -3.11%     
==========================================
  Files        1018      486     -532     
  Lines       49793    29985   -19808     
  Branches     4877        0    -4877     
==========================================
- Hits        33330    19140   -14190     
+ Misses      16340    10845    -5495     
+ Partials      123        0     -123     

Flag	Coverage Δ
cypress	?
javascript	?
python	63.83% <ø> (-0.31%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/sql_validators/postgres.py	50.00% <0.00%> (-50.00%)	⬇️
superset/databases/commands/create.py	83.67% <0.00%> (-8.17%)	⬇️
superset/databases/commands/update.py	85.71% <0.00%> (-8.17%)	⬇️
superset/db_engine_specs/sqlite.py	90.62% <0.00%> (-6.25%)	⬇️
superset/databases/commands/test_connection.py	84.78% <0.00%> (-4.35%)	⬇️
superset/utils/celery.py	96.42% <0.00%> (-3.58%)	⬇️
superset/models/core.py	85.86% <0.00%> (-2.99%)	⬇️
superset/views/core.py	72.82% <0.00%> (-2.48%)	⬇️
superset/db_engine_specs/mysql.py	89.79% <0.00%> (-2.05%)	⬇️
superset/datasets/api.py	89.49% <0.00%> (-1.83%)	⬇️
... and 540 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b8029...0c183c6. Read the comment docs.

[ktmud]

Looks good

[ktmud]

Was your screenshot based on some other branch? Because when I tested locally the indicator width is still a little off:

[kkucharc]

Was your screenshot based on some other branch? Because when I tested locally the indicator width is still a little off:

Thank you @ktmud for checking! I was pretty sure that I'm working on current master (without previous PR it my changes wouldn't help). Now, it's rebased and everything double checked.

@adam-stasiak would you like to test?

[junlincc]

tested, LGTM! ✅ Thanks for the fix!