Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(db engines): Updade DB2 connection prefix #12673

Merged
merged 1 commit into from
Jan 22, 2021
Merged

docs(db engines): Updade DB2 connection prefix #12673

merged 1 commit into from
Jan 22, 2021

Conversation

cabo40
Copy link
Contributor

@cabo40 cabo40 commented Jan 22, 2021

The connection prefix should be different if the DB2 dialect is different.

The connection prefix should be different if the DB2 dialect is different.
@codecov-io
Copy link

Codecov Report

Merging #12673 (bd9fda6) into master (d80c2ed) will decrease coverage by 3.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12673      +/-   ##
==========================================
- Coverage   66.78%   63.34%   -3.45%     
==========================================
  Files        1018      486     -532     
  Lines       49792    29982   -19810     
  Branches     4877        0    -4877     
==========================================
- Hits        33255    18991   -14264     
+ Misses      16410    10991    -5419     
+ Partials      127        0     -127     
Flag Coverage Δ
cypress ?
javascript ?
python 63.34% <ø> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/connectors/sqla/models.py 84.31% <0.00%> (-6.28%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/models/core.py 85.59% <0.00%> (-3.27%) ⬇️
... and 542 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d80c2ed...bd9fda6. Read the comment docs.

@cabo40 cabo40 changed the title Updade connection prefix docs(db engines): Updade DB2 connection prefix Jan 22, 2021
@junlincc junlincc requested a review from srinify January 22, 2021 16:07
@junlincc junlincc added the doc:developer Developer documentation label Jan 22, 2021
@srinify srinify merged commit b1c203b into apache:master Jan 22, 2021
@cabo40 cabo40 deleted the patch-1 branch January 22, 2021 21:45
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc:developer Developer documentation size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants