Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add capitalization guidelines to CONTRIBUTING.md #12685

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Add capitalization guidelines to CONTRIBUTING.md (#12343)

@rusackas @junlincc @mihir174

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina changed the title Add capitalization guidelines to CONTRIBUTING.md chore: Add capitalization guidelines to CONTRIBUTING.md Jan 22, 2021
@codecov-io
Copy link

Codecov Report

Merging #12685 (68a743d) into master (5504762) will decrease coverage by 1.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12685      +/-   ##
==========================================
- Coverage   64.55%   63.32%   -1.24%     
==========================================
  Files        1018      486     -532     
  Lines       49787    29970   -19817     
  Branches     4971        0    -4971     
==========================================
- Hits        32141    18978   -13163     
+ Misses      17468    10992    -6476     
+ Partials      178        0     -178     
Flag Coverage Δ
cypress ?
javascript ?
python 63.32% <ø> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/databases/commands/create.py 32.65% <0.00%> (-59.19%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/views/database/mixins.py 59.64% <0.00%> (-22.81%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/db_engine_specs/presto.py 81.38% <0.00%> (-6.71%) ⬇️
superset/databases/schemas.py 93.40% <0.00%> (-6.05%) ⬇️
superset/databases/dao.py 94.11% <0.00%> (-5.89%) ⬇️
superset/databases/api.py 86.55% <0.00%> (-5.47%) ⬇️
... and 552 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5504762...68a743d. Read the comment docs.

@junlincc junlincc added v1.0.1 doc:developer Developer documentation labels Jan 22, 2021
@mihir174
Copy link
Contributor

LGTM! 👍

@mihir174
Copy link
Contributor

Hey @michael-s-molina thanks for the PR! We are expecting to add more design guidelines in addition to the capitalization one.

I am thinking we could add a page for design guidelines and have the capitalization guidelines as one section within that page. The design guidelines page can go exactly where you proposed to put the capitalization guidelines on CONTRIBUTING.md

cc: @garden-of-delete

@garden-of-delete
Copy link
Contributor

LGTM!

@nytai nytai merged commit 0f8a62b into apache:master Jan 22, 2021
@mistercrunch mistercrunch added 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc:developer Developer documentation size/M v1.0.1 🍒 1.0.1 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants