-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(native-filters): Show incompatible native filters indicator #12687
fix(native-filters): Show incompatible native filters indicator #12687
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12687 +/- ##
==========================================
- Coverage 66.85% 63.32% -3.54%
==========================================
Files 1018 486 -532
Lines 49776 29970 -19806
Branches 4869 0 -4869
==========================================
- Hits 33278 18978 -14300
+ Misses 16375 10992 -5383
+ Partials 123 0 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@agatapst could you check this scenario? @junlincc Could you confirm that my expected behavior is valid? Observed: I see disabled filter in section Incompatible Filters unset.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, nice
Retested again and consulted with Agata. It looks like my issue was caused by performance on my machine (on video you can see how long everything takes). So no issue there. |
Oh apologies Adam, I didn't see your comment when I left my review. Glad it's working! |
LGTM, thank you for fixing it! next step is to get the magnifier work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
FiltersBadge_spec.tsx
- I have divided them into 'for dashboard filters' and 'for native filters'. Section 'for dashboard filters' is the same as on master, I have only added analogical tests for native filters.Fixes #12568
Closes #12568
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before incompatible section for native filters was missing.
![Zrzut ekranu 2021-01-22 o 15 02 38](https://user-images.githubusercontent.com/47450693/105500327-0bb93f80-5cc3-11eb-9cee-83638ced5a1e.png)
Now different configurations:
With some correct native filters applied and one incompatible:
With trying to apply two incompatible native filters from two different datasets:
![Zrzut ekranu 2021-01-22 o 15 09 53](https://user-images.githubusercontent.com/47450693/105500993-f0026900-5cc3-11eb-9e89-d1e756907e19.png)
With one dashboard filter applied and one incompatible native filter:
![Zrzut ekranu 2021-01-22 o 15 12 35](https://user-images.githubusercontent.com/47450693/105501375-6a32ed80-5cc4-11eb-96bc-60b447473d50.png)
With incompatible dashboard filters (without native filters):
![Zrzut ekranu 2021-01-22 o 15 23 49](https://user-images.githubusercontent.com/47450693/105502681-fbef2a80-5cc5-11eb-9cae-a33cee9486c5.png)
TEST PLAN
Enable native filters: go to
config.py
and set"DASHBOARD_NATIVE_FILTERS": True,
Go to dashboards and create native filters. One one them should be created with incompatible dataset, which cannot be applied to this dashboard.
ADDITIONAL INFORMATION
cc @junlincc @rusackas @villebro @suddjian
@adam-stasiak could you test?