Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding gatsby remove serviceworker #12692

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

craig-rueda
Copy link
Member

SUMMARY

Looks like the docs site is caching locally, which prevents changes from going out effectively.

This PR removes the local caching mechanism.

@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #12692 (9ac263d) into master (57fa6d2) will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12692      +/-   ##
==========================================
- Coverage   66.93%   66.65%   -0.28%     
==========================================
  Files        1018     1018              
  Lines       49790    49790              
  Branches     4875     4875              
==========================================
- Hits        33326    33190     -136     
- Misses      16341    16477     +136     
  Partials      123      123              
Flag Coverage Δ
cypress 50.95% <ø> (+<0.01%) ⬆️
javascript 60.95% <ø> (ø)
python 63.67% <ø> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/db_engine_specs/presto.py 81.38% <0.00%> (-7.15%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 88.04% <0.00%> (-0.82%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 93.65% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57fa6d2...9ac263d. Read the comment docs.

@ktmud
Copy link
Member

ktmud commented Jan 22, 2021

Why was the symptom of the problems you were seeing? Would properly enable gatsby-plugin-offline also fix it?

According to Gatsby doc, it seems gatsby-plugin-remove-serviceworker is used to remove outdated service workers.

@craig-rueda craig-rueda merged commit 57b0bd2 into apache:master Jan 22, 2021
@craig-rueda craig-rueda deleted the craig/disable-gatsby-cache branch January 22, 2021 21:53
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants