Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update latest tag action to use set-output #12706

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

eschutho
Copy link
Member

SUMMARY

GitHub recently deprecated set-env with their latest actions security updates. This replaces set-env with set-output
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

TEST PLAN

manually tested with nektos/act utility

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho changed the title update latest tag action to use set-output fix: update latest tag action to use set-output Jan 23, 2021
@eschutho
Copy link
Member Author

@dpgaspar @villebro @ktmud

@codecov-io
Copy link

codecov-io commented Jan 23, 2021

Codecov Report

Merging #12706 (9b144c6) into master (b8a93fd) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12706      +/-   ##
==========================================
+ Coverage   66.79%   66.88%   +0.08%     
==========================================
  Files        1019     1019              
  Lines       49824    49825       +1     
  Branches     4877     4877              
==========================================
+ Hits        33281    33323      +42     
+ Misses      16419    16379      -40     
+ Partials      124      123       -1     
Flag Coverage Δ
cypress 50.94% <ø> (+1.34%) ⬆️
javascript 60.93% <ø> (ø)
python 64.05% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 82.25% <0.00%> (-6.28%) ⬇️
superset/models/core.py 88.58% <0.00%> (-0.28%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 62.42% <0.00%> (+0.21%) ⬆️
superset/datasets/commands/importers/v1/utils.py 56.16% <0.00%> (+0.60%) ⬆️
superset-frontend/src/reduxUtils.ts 79.74% <0.00%> (+1.26%) ⬆️
...set-frontend/src/dashboard/util/getDropPosition.js 93.65% <0.00%> (+1.58%) ⬆️
...e/components/controls/FilterControl/AdhocFilter.js 96.92% <0.00%> (+3.07%) ⬆️
superset-frontend/src/SqlLab/components/App.jsx 64.28% <0.00%> (+7.14%) ⬆️
...nd/src/dashboard/components/gridComponents/Tab.jsx 74.07% <0.00%> (+7.40%) ⬆️
...c/dashboard/components/gridComponents/Markdown.jsx 90.38% <0.00%> (+7.69%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a93fd...9b144c6. Read the comment docs.

@nytai nytai merged commit 80deb4e into apache:master Jan 25, 2021
@nytai nytai deleted the elizabeth/update-latest-tag branch January 25, 2021 00:40
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants