fix: samples should not be timeseries

[betodealmeida]

SUMMARY

When we fetch samples for a given viz we need to ensure the is_timeseries attribute is false, otherwise Superset will add a group by on the temporal column, resuilting in an invalid column:

SELECT ts AS ts,
       name AS name,
       text AS text,
       DATE(ts) AS __timestamp  -- HERE
FROM
  (SELECT m.ts,
          c.name,
          m.text
   FROM messages m
   JOIN channels c ON m.channel_id = c.id) AS expr_qry
WHERE ts >= STR_TO_DATE('2020-10-27 00:00:00.000000', '%Y-%m-%d %H:%i:%s.%f')
  AND ts < STR_TO_DATE('2021-01-27 00:00:00.000000', '%Y-%m-%d %H:%i:%s.%f')
  AND name != 'github-notifications'
GROUP BY DATE(ts)  -- HERE
LIMIT 1000

The query above is invalid because the GROUP BY should contain all non-aggregation expressions from the SELECT.

Because of this, some charts fail to load their samples.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

Open chart and navigated to "DATA" -> "VIEW SAMPLES", now it works as expected.

ADDITIONAL INFORMATION

• Has associated issue: [Sample]View data section shows no data of new samples dataset #12504
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #12796 (979f908) into master (044d1ae) will increase coverage by 4.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12796      +/-   ##
==========================================
+ Coverage   67.00%   71.40%   +4.40%     
==========================================
  Files        1022      534     -488     
  Lines       50047    19930   -30117     
  Branches     4914     4914              
==========================================
- Hits        33533    14232   -19301     
+ Misses      16390     5574   -10816     
  Partials      124      124              

Flag	Coverage Δ
cypress	50.89% <ø> (ø)
javascript	61.69% <ø> (ø)
python	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...igrations/versions/763d4b211ec9_fixing_audit_fk.py
superset/views/utils.py
superset/examples/world_bank.py
superset/datasets/filters.py
...s/versions/b6fa807eac07_make_names_non_nullable.py
superset/reports/api.py
superset/examples/countries.py
superset/models/dynamic_plugins.py
...t/annotation_layers/annotations/commands/delete.py
...perset/dashboards/commands/importers/dispatcher.py
... and 477 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044d1ae...979f908. Read the comment docs.

[villebro]

LGTM!