-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade react-dnd to 11.1.3 #12815
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12815 +/- ##
==========================================
- Coverage 67.01% 63.39% -3.62%
==========================================
Files 1022 488 -534
Lines 50102 30140 -19962
Branches 5191 0 -5191
==========================================
- Hits 33574 19108 -14466
+ Misses 16397 11032 -5365
+ Partials 131 0 -131
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tested and played in Dashboard and Explore for a while not seeing noticeable regression. since we are bumping 9 major versions, would like to get you guys' approval on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
SUMMARY
Currently we use an ancient version of react-dnd 2.5.4. The goal of this PR is to bump the library to the latest version in order to get rid of tech debt before we move to implementing new drag'n'drop features.
closes: apache-superset/superset-roadmap#148
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
CC: @villebro @junlincc @adam-stasiak
This PR requires extensive testing, especially on Explore and Dashboard Builder views, where we use dnd feature