Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade react-dnd to 11.1.3 #12815

Merged
merged 8 commits into from
Jan 29, 2021
Merged

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jan 28, 2021

SUMMARY

Currently we use an ancient version of react-dnd 2.5.4. The goal of this PR is to bump the library to the latest version in order to get rid of tech debt before we move to implementing new drag'n'drop features.

closes: apache-superset/superset-roadmap#148

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

CC: @villebro @junlincc @adam-stasiak
This PR requires extensive testing, especially on Explore and Dashboard Builder views, where we use dnd feature

@junlincc junlincc added dashboard:editmode Related to te Dashboard edit mode explore:control Related to the controls panel of Explore labels Jan 28, 2021
@codecov-io
Copy link

codecov-io commented Jan 28, 2021

Codecov Report

Merging #12815 (7eb24c8) into master (32f2c45) will decrease coverage by 3.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12815      +/-   ##
==========================================
- Coverage   67.01%   63.39%   -3.62%     
==========================================
  Files        1022      488     -534     
  Lines       50102    30140   -19962     
  Branches     5191        0    -5191     
==========================================
- Hits        33574    19108   -14466     
+ Misses      16397    11032    -5365     
+ Partials      131        0     -131     
Flag Coverage Δ
cypress ?
javascript ?
python 63.39% <ø> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 73.84% <0.00%> (-17.31%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/connectors/sqla/models.py 84.31% <0.00%> (-6.28%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/models/core.py 85.59% <0.00%> (-3.27%) ⬇️
... and 532 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f2c45...7eb24c8. Read the comment docs.

@kgabryje kgabryje changed the title Chore: Upgrade react-dnd to 11.1.3 chore: Upgrade react-dnd to 11.1.3 Jan 28, 2021
@junlincc
Copy link
Member

tested and played in Dashboard and Explore for a while not seeing noticeable regression. since we are bumping 9 major versions, would like to get you guys' approval on this one.
@ktmud @graceguo-supercat @etr2460 @michellethomas

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ktmud ktmud merged commit fcaa0ac into apache:master Jan 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:editmode Related to te Dashboard edit mode explore:control Related to the controls panel of Explore size/L 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard&explore] bumping react-dnd library from 2.5.4 to latest⚠️
5 participants