refactor: dbapi exception mapping for dbapi's #12869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12869 +/- ##
==========================================
- Coverage 67.04% 63.41% -3.63%
==========================================
Files 1022 490 -532
Lines 50186 30245 -19941
Branches 5204 0 -5204
==========================================
- Hits 33647 19181 -14466
+ Misses 16404 11064 -5340
+ Partials 135 0 -135
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbarrett
reviewed
Feb 1, 2021
superset/db_engine_specs/base.py
Outdated
| @classmethod | ||
| def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception], Type[Exception]]: | ||
| """ | ||
| Each engine can implement and converge it's own specific exceptions into |
There was a problem hiding this comment.
Grammar nit: "its" not "it's"
There was a problem hiding this comment.
Fixed, yes that's a good point, a simple way of doing is:
if not new_exception:
return SupersetDBAPIError(str(exception))
But can have broader implications, I want to place the base for this, and just interfere on the defined exceptions for Elasticsearch and clickhouse (for now).
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 3, 2021
* master: (23 commits) feat(explore): clear search on dataset change (apache#12909) chore: remove SIP-38 feature flag (apache#12894) fix: Config for dataset health check (apache#12906) fix(chart): allow null for most query object props (apache#12905) feat: add separate endpoint to fetch function names for autocomplete (apache#12840) chore: add required review on master (apache#12694) fix: comment typo (apache#12898) Migrates Radio component from Bootstrap to AntD. (apache#12738) fix: allow users to reset their passwords (apache#12886) fix(explore): missing select when groupby without metrics (apache#12890) refactor: dbapi exception mapping for dbapi's (apache#12869) feat(style-theme): add support for custom superset themes (apache#12858) chore(lint): fix pre-commit error (apache#12884) refactor(color-schemes): refactor setting of color schemes (apache#12857) feat(native-filters): Add defaultValue for Native filters modal (apache#12199) feat(release): add github token to changelog script (apache#12872) fix(menu): always show settings dropdown (apache#12877) Migrates Label component from Bootstrap to AntD. (apache#12774) [Helm] Automate datasource import (apache#10771) build: Skip loading example data from configs in CI (apache#12610) ...
6 tasks
|
|
||
| :return: A map of driver specific exception to superset custom exceptions | ||
| """ | ||
| return {} |
There was a problem hiding this comment.
@dpgaspar you should be able to build this automatically, since the SQLAlchemy dialect exposts the DB API module, which should have the exceptions at the top level with standard names.
Something like this (untested):
dbapi = cls.get_engine(database).dialect.dbapi()
return {
getattr(dbapi, name): getattr(superset.exceptions, f"SupersetDBAPI{name}"
for name in {"ProgrammingError", "DatabaseError", etc}
}Maybe have this as the base method and allow subclasses to define their own?
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Lays the foundation for implementing superset's custom DBAPI exceptions from driver exceptions (following a @villebro idea/proposal).
DBAPI drivers raise custom exceptions or straight unexpected exceptions, this causes several problems e.g.: UI messages with sensitive text, use of broad exceptions, not possible to use more fine grain actions when an error occurs at the DBAPI.
Fixes: #11822
ADDITIONAL INFORMATION