-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Bootstrap to AntD - DropdownButton #13002
refactor: Bootstrap to AntD - DropdownButton #13002
Conversation
131003b
to
b6ee14a
Compare
Codecov Report
@@ Coverage Diff @@
## master #13002 +/- ##
==========================================
+ Coverage 53.06% 58.42% +5.36%
==========================================
Files 489 468 -21
Lines 17314 15873 -1441
Branches 4482 4080 -402
==========================================
+ Hits 9187 9274 +87
+ Misses 8127 6599 -1528
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related, @michael-s-molina Michael, could you double check if we covered the casing change in the main menu dropdown? thanks! |
@junlincc This text is translated on the server side (Python). This is the part that Kasia was working on. We should discuss how to continue this today in our meeting. |
superset-frontend/src/dashboard/components/menu/PopoverDropdown.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/menu/WithPopoverMenu.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/menu/WithPopoverMenu.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b6ee14a
to
5034253
Compare
SUMMARY
See: #10254
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
@rusackas @junlincc
TEST PLAN
1 - Open any screen that contains a
DropdownButton
(explore, dashboard -> edit, etc.)2 - All
DropdownButton
components should have the same theme and behaviorADDITIONAL INFORMATION