refactor: Move raise_for_dashboard_access to security manager

[bolkedebruin]

SUMMARY

Access policies might be stored or obtained externally from Superset (e.g. by a sidecar with Open Policy Agent or Apache Ranger). raise_for_dashboard_access was located in "dashboard" so it could not be overridden by a security manager implementation. This aligns the implementation with other security features.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

This has the same logic as before so same tests apply.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

cc @amitmiran137

[codecov-io]

Codecov Report

Merging #13235 (0e7dfee) into master (2ce7982) will increase coverage by 27.07%.
The diff coverage is 79.77%.

@@             Coverage Diff             @@
##           master   #13235       +/-   ##
===========================================
+ Coverage   53.06%   80.13%   +27.07%     
===========================================
  Files         489      298      -191     
  Lines       17314    24194     +6880     
  Branches     4482        0     -4482     
===========================================
+ Hits         9187    19388    +10201     
+ Misses       8127     4806     -3321     

Flag	Coverage Δ
cypress	?
python	80.13% <79.77%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/constants.py	100.00% <ø> (ø)
superset/examples/birth_names.py	73.19% <ø> (ø)
superset/models/dashboard.py	76.77% <ø> (ø)
superset/connectors/sqla/views.py	62.43% <4.34%> (ø)
superset/views/datasource.py	88.70% <16.66%> (ø)
superset/viz.py	58.61% <27.27%> (ø)
superset/views/core.py	71.80% <71.42%> (ø)
superset/charts/commands/exceptions.py	92.85% <77.77%> (ø)
superset/utils/core.py	88.26% <87.50%> (ø)
superset/db_engine_specs/trino.py	90.47% <90.47%> (ø)
... and 695 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd443d...0e7dfee. Read the comment docs.

[amitmiran137]

LGTM!

[dpgaspar]

LGMT Thank you @bolkedebruin