Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change data-test-id to data-test in FlashProvider #13304

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Feb 23, 2021

SUMMARY

CI for #13220 passed before #13292 was merged. Then both PRs are merged without rerunning the CI. Now tests in master is broken.

This adapts the tests in #13220 to the new configuration updated by #13292

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

No visible changes to users. CI should pass.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@yardz
Copy link
Contributor Author

yardz commented Feb 23, 2021

@ktmud I believe this has priority as it may be holding other PRs

Like this: #13302

@ktmud ktmud changed the title test: change "data-test-id" to "data-test" test: change data-test-id to data-test in FlashProvider Feb 23, 2021
@codecov-io
Copy link

codecov-io commented Feb 23, 2021

Codecov Report

Merging #13304 (0b2df82) into master (99a0c8a) will decrease coverage by 19.01%.
The diff coverage is 35.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #13304       +/-   ##
===========================================
- Coverage   77.15%   58.13%   -19.02%     
===========================================
  Files         866      480      -386     
  Lines       45005    16003    -29002     
  Branches     5357     4130     -1227     
===========================================
- Hits        34723     9304    -25419     
+ Misses      10159     6699     -3460     
+ Partials      123        0      -123     
Flag Coverage Δ
cypress 58.13% <35.55%> (-0.38%) ⬇️
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/SqlLab/components/TableElement.jsx 5.88% <0.00%> (-80.64%) ⬇️
...-frontend/src/common/components/Collapse/index.tsx 94.73% <ø> (ø)
...t-frontend/src/common/components/Tooltip/index.tsx 100.00% <ø> (ø)
superset-frontend/src/common/components/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Button/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/ListView/utils.ts 84.34% <ø> (-1.61%) ⬇️
...set-frontend/src/components/ModalTrigger/index.jsx 95.65% <ø> (-4.35%) ⬇️
...dashboard/components/FiltersBadge/DetailsPanel.tsx 54.05% <ø> (-7.31%) ⬇️
.../src/explore/components/ControlPanelsContainer.jsx 86.73% <ø> (ø)
...frontend/src/explore/components/DataTablesPane.tsx 56.52% <ø> (-5.51%) ⬇️
... and 746 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a05d6a...0b2df82. Read the comment docs.

@ktmud ktmud merged commit 8ef52ba into apache:master Feb 23, 2021
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants