chore: Moves AsyncSelect component and tests to own folder #13314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13314 +/- ##
===========================================
- Coverage 77.20% 58.50% -18.71%
===========================================
Files 872 480 -392
Lines 45101 16003 -29098
Branches 5435 4130 -1305
===========================================
- Hits 34820 9362 -25458
+ Misses 10158 6641 -3517
+ Partials 123 0 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pkdotson
reviewed
Feb 25, 2021
| @@ -21,7 +21,7 @@ import PropTypes from 'prop-types'; | |||
| // TODO: refactor this with `import { AsyncSelect } from src/components/Select` | |||
| import { Select } from 'src/components/Select'; | |||
| import { t, SupersetClient } from '@superset-ui/core'; | |||
| import { getClientErrorObject } from '../utils/getClientErrorObject'; | |||
| import { getClientErrorObject } from '../../utils/getClientErrorObject'; | |||
There was a problem hiding this comment.
nit: think we want absolute paths here src/utils/getClientErrorObject
There was a problem hiding this comment.
tagging this with revisit:src path for someone else to come along and touch up later. On with the show!
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Moves
AsyncSelectcomponent and tests to own folder.TEST PLAN
1 - Execute
AsyncSelecttests2 - All tests should pass
@rusackas
ADDITIONAL INFORMATION