Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: healtcheck defined in dockerfile does not apply to all use-cases #14231

Closed
wants to merge 1 commit into from
Closed

build: healtcheck defined in dockerfile does not apply to all use-cases #14231

wants to merge 1 commit into from

Conversation

kopernic-pl
Copy link

@kopernic-pl kopernic-pl commented Apr 19, 2021

healtcheck defined in dockerfile does not apply to all use-cases (comands) for image, causing healtcheck failed when using compose when no healthcheck exists

SUMMARY

Container healtcheck from dockerfile checks connectivity to locally running 8088 - which is running only in 'superset' container, not workers or beats or init one

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

run compose /dev compose - there should be no failed healtcheck containers running

ADDITIONAL INFORMATION

  • Has associated issue: unhealthy "app" and "worker" docker containers #12895
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…mands) for image, causing healtcheck failed when using compose when no healthcheck exists
@kopernic-pl kopernic-pl changed the title healtcheck defined in dockerfile does not apply to all use-cases build: healtcheck defined in dockerfile does not apply to all use-cases Apr 19, 2021
@kopernic-pl
Copy link
Author

Possibly somewhat related to #13129

@amitmiran137 amitmiran137 requested a review from craig-rueda June 29, 2021 10:17
@craig-rueda
Copy link
Member

craig-rueda commented Jun 30, 2021

Does it make sense to yank this out of the docker file instead? Then you can just re add it into the superset container only in the compose file. Or just leave it out all together. I'm not convinced we need it for compose.

@kopernic-pl
Copy link
Author

There is one image that does multiple things. It has healthcheck inside but only for one aspect of its operations. I agree that moving HC out and defining it externally is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants