-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Bootstrap to AntD - Form - iteration 2 #14379
refactor: Bootstrap to AntD - Form - iteration 2 #14379
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14379 +/- ##
==========================================
- Coverage 77.15% 76.81% -0.34%
==========================================
Files 954 958 +4
Lines 48189 48277 +88
Branches 6002 6033 +31
==========================================
- Hits 37180 37084 -96
- Misses 10812 10998 +186
+ Partials 197 195 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0f3851e
to
1a91729
Compare
/testenv up |
@pkdotson Ephemeral environment spinning up at http://54.149.213.162:8080. Credentials are |
I noticed some slight differences from production and the testing env for save chart modal. The label texts are darker in your pr while in production the text is lighter gray (kinda hard to see from my poor resolution screenshot, copied the css): Also the highlighting is a little different in the form. Might want to check with desgin @mihir174 if the new highlight works, just to be consistent throughout the app. |
@pkdotson Thanks for reviewing. Those changes were intentional.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTG!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Migrates Form components from Bootstrap to AntD (iteration 2).
See: #10254
@rusackas @junlincc @pkdotson
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
1 - Access the touched components
2 - Check that the layouts and functionality are working
ADDITIONAL INFORMATION