Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Bootstrap to AntD - Form - iteration 2 #14379

Merged
merged 1 commit into from
May 6, 2021

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Apr 27, 2021

SUMMARY

Migrates Form components from Bootstrap to AntD (iteration 2).

See: #10254

@rusackas @junlincc @pkdotson

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-04-26 at 4 46 53 PM

Screen Shot 2021-04-27 at 10 24 04 AM

Screen Shot 2021-04-27 at 2 41 03 PM

Screen Shot 2021-04-27 at 3 27 24 PM

Screen Shot 2021-04-27 at 10 44 31 AM

Screen Shot 2021-04-27 at 3 28 10 PM

TEST PLAN

1 - Access the touched components
2 - Check that the layouts and functionality are working

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #14379 (1a91729) into master (20ab086) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14379      +/-   ##
==========================================
- Coverage   77.15%   76.81%   -0.34%     
==========================================
  Files         954      958       +4     
  Lines       48189    48277      +88     
  Branches     6002     6033      +31     
==========================================
- Hits        37180    37084      -96     
- Misses      10812    10998     +186     
+ Partials      197      195       -2     
Flag Coverage Δ
javascript 71.36% <100.00%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/CRUD/Field.jsx 83.33% <ø> (ø)
...shboard/components/filterscope/FilterFieldItem.jsx 100.00% <ø> (ø)
...-frontend/src/explore/components/ControlHeader.jsx 85.18% <ø> (ø)
...rontend/src/explore/components/EmbedCodeButton.jsx 80.76% <ø> (ø)
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 78.78% <ø> (ø)
...rc/explore/components/controls/ViewportControl.jsx 82.60% <ø> (ø)
...rontend/src/visualizations/FilterBox/FilterBox.jsx 56.60% <ø> (ø)
...erset-frontend/src/SqlLab/components/SaveQuery.tsx 75.00% <100.00%> (ø)
...tend/src/SqlLab/components/ScheduleQueryButton.tsx 29.23% <100.00%> (ø)
...rset-frontend/src/components/DeleteModal/index.tsx 100.00% <100.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ab086...1a91729. Read the comment docs.

@pkdotson
Copy link
Member

pkdotson commented May 3, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

@pkdotson Ephemeral environment spinning up at http://54.149.213.162:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc junlincc added the frontend:refactor Related to refactoring the frontend label May 5, 2021
@pkdotson
Copy link
Member

pkdotson commented May 5, 2021

I noticed some slight differences from production and the testing env for save chart modal. The label texts are darker in your pr while in production the text is lighter gray (kinda hard to see from my poor resolution screenshot, copied the css):
Screen Shot 2021-05-04 at 11 20 59 PM
Screen Shot 2021-05-04 at 11 23 23 PM
Screen Shot 2021-05-04 at 11 23 42 PM

Screen Shot 2021-05-04 at 11 21 29 PM

Also the highlighting is a little different in the form. Might want to check with desgin @mihir174 if the new highlight works, just to be consistent throughout the app.
Screen Shot 2021-05-04 at 11 29 14 PM
Screen Shot 2021-05-04 at 11 29 25 PM

@michael-s-molina
Copy link
Member Author

I noticed some slight differences from production and the testing env for save chart modal. The label texts are darker in your pr while in production the text is lighter gray (kinda hard to see from my poor resolution screenshot, copied the css):
Screen Shot 2021-05-04 at 11 20 59 PM
Screen Shot 2021-05-04 at 11 23 23 PM
Screen Shot 2021-05-04 at 11 23 42 PM

Screen Shot 2021-05-04 at 11 21 29 PM

Also the highlighting is a little different in the form. Might want to check with desgin @mihir174 if the new highlight works, just to be consistent throughout the app.
Screen Shot 2021-05-04 at 11 29 14 PM
Screen Shot 2021-05-04 at 11 29 25 PM

@pkdotson Thanks for reviewing. Those changes were intentional.

  • The color of label texts in production doesn't exist currently in our theme. I replaced it with the theme color grayscale.base.
  • The "Chart Name" change was to use our Input component. There's another PR that changes the Input theme to be the same as the AntD default theme and then the color will be the same as production.

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTG!

@rusackas rusackas merged commit 331310d into apache:master May 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels frontend:refactor Related to refactoring the frontend size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants