Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra query in Dashboard when native filter enabled #14770

Merged
merged 1 commit into from
May 24, 2021
Merged

fix: extra query in Dashboard when native filter enabled #14770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,11 @@ const FilterBar: React.FC<FiltersBarProps> = ({
setIsFilterSetChanged(tab !== TabIds.AllFilters);
setDataMaskSelected(draft => {
const children = cascadeChildren[filter.id] || [];
// force instant updating on initialization or for parent filters
if (filter.isInstant || children.length > 0) {
// force instant updating on initialization or for parent filters when dataMaskSelected has filter
if (
dataMaskSelected[filter.id] &&
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that DataMaskSelected contains the filter, rather than the initial object(empty object).

(filter.isInstant || children.length > 0)
) {
dispatch(updateDataMask(filter.id, dataMask));
}

Expand Down