Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding FORCE_SSL as feature flag in config.py #14934

Merged
merged 3 commits into from
Jun 2, 2021
+3 −0
Merged

feat: Adding FORCE_SSL as feature flag in config.py #14934

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9494edf
starting
AAfghahi Jun 1, 2021
42ccdc7
added explanation
AAfghahi Jun 2, 2021
6f17e95
Update superset/config.py
AAfghahi Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions superset/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
# for report with type 'report' still send with email and slack message with
# screenshot and link
"ALERTS_ATTACH_REPORTS": True,
"FORCE_SSL": False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add documentation about what this flag does?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! where should I add the documentation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline, similarly to the other feature flags would be great, thanks!

}

# Feature flags may also be set via 'SUPERSET_FEATURE_' prefixed environment vars.
Expand Down