Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make dataset update methods static instead of global #16044

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Aug 3, 2021

SUMMARY

Follow up to #15786 per @john-bodley's request. This seems cleaner

TESTING INSTRUCTIONS

CI, testenv

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @john-bodley @villebro

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #16044 (3e3aba8) into master (4cb79e5) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

❗ Current head 3e3aba8 differs from pull request most recent head 449cc4a. Consider uploading reports for the commit 449cc4a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16044      +/-   ##
==========================================
- Coverage   76.90%   76.66%   -0.25%     
==========================================
  Files         995      995              
  Lines       52842    52844       +2     
  Branches     6709     6709              
==========================================
- Hits        40640    40513     -127     
- Misses      11976    12105     +129     
  Partials      226      226              
Flag Coverage Δ
hive ?
mysql 81.62% <100.00%> (+<0.01%) ⬆️
postgres 81.64% <100.00%> (+<0.01%) ⬆️
presto ?
python 81.69% <100.00%> (-0.48%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/druid/models.py 82.95% <100.00%> (+0.01%) ⬆️
superset/connectors/sqla/models.py 88.08% <100.00%> (-1.66%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/connectors/sqla/utils.py 87.50% <0.00%> (-4.17%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb79e5...449cc4a. Read the comment docs.

@etr2460
Copy link
Member Author

etr2460 commented Aug 3, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

@etr2460 Ephemeral environment spinning up at http://52.89.239.122:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@etr2460 etr2460 merged commit 7c059cd into apache:master Aug 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants