-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Rockset db engine spec #16167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I look forward to testing this! LGTM, one minor comment. Also, if you're in the mood for adding unit tests for some of those Rockset funct (eopch_to_dttm
, epocu_ms_to_dttm
, convert_dttm
etc), it will help protect us against regressions.
Codecov Report
@@ Coverage Diff @@
## master #16167 +/- ##
==========================================
- Coverage 76.73% 76.61% -0.13%
==========================================
Files 996 998 +2
Lines 52999 53228 +229
Branches 6738 6764 +26
==========================================
+ Hits 40668 40778 +110
- Misses 12102 12220 +118
- Partials 229 230 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* rockset prototype * rockset * t * removed print / logging * set a more specific version range for Rockset library (cherry picked from commit 5f060a2)
* rockset prototype * rockset * t * removed print / logging * set a more specific version range for Rockset library
* rockset prototype * rockset * t * removed print / logging * set a more specific version range for Rockset library
Adds db_engine_spec for Rockset (https://rockset.com/)