Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Rockset db engine spec #16167

Merged
merged 8 commits into from
Aug 18, 2021
Merged

feat: Adding Rockset db engine spec #16167

merged 8 commits into from
Aug 18, 2021

Conversation

srinify
Copy link
Contributor

@srinify srinify commented Aug 10, 2021

Adds db_engine_spec for Rockset (https://rockset.com/)

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I look forward to testing this! LGTM, one minor comment. Also, if you're in the mood for adding unit tests for some of those Rockset funct (eopch_to_dttm, epocu_ms_to_dttm, convert_dttm etc), it will help protect us against regressions.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #16167 (1ae627c) into master (ccfc95f) will decrease coverage by 0.12%.
The diff coverage is 71.61%.

❗ Current head 1ae627c differs from pull request most recent head b567aa6. Consider uploading reports for the commit b567aa6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16167      +/-   ##
==========================================
- Coverage   76.73%   76.61%   -0.13%     
==========================================
  Files         996      998       +2     
  Lines       52999    53228     +229     
  Branches     6738     6764      +26     
==========================================
+ Hits        40668    40778     +110     
- Misses      12102    12220     +118     
- Partials      229      230       +1     
Flag Coverage Δ
hive ?
mysql 81.54% <76.81%> (-0.07%) ⬇️
postgres 81.57% <76.81%> (-0.07%) ⬇️
presto 81.40% <76.81%> (-0.02%) ⬇️
python 81.83% <76.81%> (-0.32%) ⬇️
sqlite 81.21% <76.81%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Form/Form.tsx 100.00% <ø> (ø)
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 46.42% <ø> (-0.94%) ⬇️
...rontend/src/explore/components/optionRenderers.tsx 100.00% <ø> (ø)
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 72.61% <ø> (ø)
...set-frontend/src/views/CRUD/data/database/types.ts 100.00% <ø> (ø)
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx 73.17% <0.00%> (-1.83%) ⬇️
...c/visualizations/TimeTable/TimeTableChartPlugin.js 75.00% <ø> (ø)
superset/common/query_object.py 90.66% <ø> (ø)
superset/datasets/commands/importers/v1/utils.py 58.97% <0.00%> (ø)
superset/examples/bart_lines.py 27.58% <0.00%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccfc95f...b567aa6. Read the comment docs.

@villebro villebro merged commit 5f060a2 into apache:master Aug 18, 2021
@villebro villebro deleted the sandbox branch August 18, 2021 10:05
@villebro villebro added the v1.3 label Sep 6, 2021
villebro pushed a commit that referenced this pull request Sep 6, 2021
* rockset prototype

* rockset

* t

* removed print / logging

* set a more specific version range for Rockset library

(cherry picked from commit 5f060a2)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* rockset prototype

* rockset

* t

* removed print / logging

* set a more specific version range for Rockset library
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* rockset prototype

* rockset

* t

* removed print / logging

* set a more specific version range for Rockset library
@mistercrunch mistercrunch added 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M v1.3 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants