fix: SQL Lab cancel query in Redshift database connection does not wo…

[yourssvk]

…rk #16325

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[yourssvk]

The changes are similar to the corresponding option in Postgres's cancel SQL option in SQL Lab

[codecov]

Codecov Report

Merging #16326 (14d3916) into master (2c595b0) will decrease coverage by 9.92%.
The diff coverage is n/a.

❗ Current head 14d3916 differs from pull request most recent head 66d3dce. Consider uploading reports for the commit 66d3dce to get more accurate results

@@            Coverage Diff             @@
##           master   #16326      +/-   ##
==========================================
- Coverage   76.63%   66.71%   -9.93%     
==========================================
  Files        1000     1750     +750     
  Lines       53426    65431   +12005     
  Branches     6819     6906      +87     
==========================================
+ Hits        40945    43653    +2708     
- Misses      12244    20028    +7784     
- Partials      237     1750    +1513     

Flag	Coverage Δ
hive	53.77% <ø> (-27.61%)	⬇️
mysql	?
postgres	?
presto	53.63% <ø> (-27.86%)	⬇️
python	82.61% <ø> (+0.44%)	⬆️
sqlite	82.24% <ø> (+0.94%)	⬆️
unit	50.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ntend/src/dashboard/util/replaceUndefinedByNull.ts	0.00% <0.00%> (-100.00%)	⬇️
...oard/components/gridComponents/new/NewMarkdown.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset/tasks/slack_util.py	0.00% <0.00%> (-86.96%)	⬇️
...d/src/filters/components/Time/TimeFilterPlugin.tsx	0.00% <0.00%> (-86.67%)	⬇️
...ts/nativeFilters/FilterBar/FilterControls/state.ts	0.00% <0.00%> (-78.58%)	⬇️
superset-frontend/src/components/Slider/index.tsx	0.00% <0.00%> (-75.00%)	⬇️
...Filters/FilterBar/FilterControls/FilterControl.tsx	29.03% <0.00%> (-70.97%)	⬇️
...ntend/src/filters/components/GroupBy/buildQuery.ts	0.00% <0.00%> (-66.67%)	⬇️
...tend/src/filters/components/Time/transformProps.ts	0.00% <0.00%> (-66.67%)	⬇️
...end/src/filters/components/TimeGrain/buildQuery.ts	0.00% <0.00%> (-66.67%)	⬇️
... and 1796 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c595b0...66d3dce. Read the comment docs.

[eschutho]

Thank you @yourssvk, this looks great. I'm closing and reopening this PR to rerun some E2E tests that have failed and are likely flaky.

[yourssvk]

Hi @eschutho Can this be Merged? Any issues?

[eschutho]

@yourssvk sorry for the delay. It looks like there's just one linting error that's failing the tests. Can you try running pre-commit locally to fix it? There are instructions isn https://github.com/apache/superset/blob/master/CONTRIBUTING.md how to get pre-commit running.

[gaurav7261]

@yourssvk I'm getting empty query id while superset code calling cancel_query_id = db_engine_spec.get_cancel_query_id(cursor, query) in sql_lab.py with engine ReshiftSpec, while for postgres spec,I get queryid, so stop query is working fine in case of postgres but not in redshift, did some logging to verify, here is the log
for postgres

2023-10-31 08:48:29,251:INFO:superset.sql_lab:15965
<class 'superset.db_engine_specs.postgres.PostgresEngineSpec'>```
where 15965 is postgres query id but for redshift sql lab
```None
2023-10-31 08:44:28,331:INFO:superset.sql_lab:None
<class 'superset.db_engine_specs.redshift-bak.RedshiftEngineSpec'>```
it is returning null, my version is 2.1.1, is it known issue