-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trino support server-cert #16346
Conversation
6f96b04
to
c3dc000
Compare
Codecov Report
@@ Coverage Diff @@
## master #16346 +/- ##
=======================================
Coverage 76.81% 76.82%
=======================================
Files 1049 1049
Lines 56654 56682 +28
Branches 7851 7851
=======================================
+ Hits 43517 43544 +27
- Misses 12884 12885 +1
Partials 253 253
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
c3dc000
to
cc36023
Compare
cc36023
to
11fdb4a
Compare
11fdb4a
to
5ff26e1
Compare
Hello @mistercrunch, could you please review this one |
5ff26e1
to
d653705
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, really big thanks for this added feature! Waiting for tests to pass, if all is good I think this is good to go.
@dungdm93 apparently there's a flaky linting rule that's failing CI - let me try to fix that |
Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
6f0b014
to
86c15da
Compare
Many thank @villebro for your support. |
Signed-off-by: Đặng Minh Dũng dungdm93@live.com
SUMMARY
Add support Server certificate for Trino database
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Write & pass unit-tests
ADDITIONAL INFORMATION