Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show run button when time series column is updated. #16366

Merged
merged 1 commit into from
Aug 20, 2021
Merged

fix: show run button when time series column is updated. #16366

merged 1 commit into from
Aug 20, 2021

Conversation

pkdotson
Copy link
Member

SUMMARY

This fix ensure that the state change is detected when collection control is updated.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-08-19.at.7.03.42.PM.mov

TESTING INSTRUCTIONS

Go to time series chart and add a metric in the time series column. Add some metric properties and ensure that run button state is updated.

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #16366 (c6e81d8) into master (50d896f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c6e81d8 differs from pull request most recent head ec98201. Consider uploading reports for the commit ec98201 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16366   +/-   ##
=======================================
  Coverage   76.51%   76.51%           
=======================================
  Files        1000     1000           
  Lines       53479    53480    +1     
  Branches     6815     6815           
=======================================
+ Hits        40917    40918    +1     
  Misses      12326    12326           
  Partials      236      236
Flag Coverage Δ
javascript 70.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/components/controls/CollectionControl/index.jsx 83.78% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d896f...ec98201. Read the comment docs.

@junlincc
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://34.219.135.160:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc
Copy link
Member

LGTM! i assume it works in dnd and dnd hybrid as well? is it possible to remove this "+" and replace it with the ghost button?in a different pr of course.

@pkdotson
Copy link
Member Author

LGTM! i assume it works in dnd and dnd hybrid as well? is it possible to remove this "+" and replace it with the ghost button?in a different pr of course.

Yep it work with dnd and dnd hybrid as well. Yes I'll do that separate.

rusackas
rusackas approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 3faf653 into apache:master Aug 20, 2021
@rusackas rusackas deleted the fix-time-series branch August 20, 2021 23:47
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

MaxHuiYYDS pushed a commit to MaxHuiYYDS/superset that referenced this pull request Aug 22, 2021
@pkdotson
initial commit (apache#16366)
c1c0d2c
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Aug 24, 2021
Merge branch 'master' into feat/fileter_set
0465379 
* master: (582 commits)
  feat: config to customize bootstrap data overrides (apache#16386)
  fix: regex for multi-region IPs (apache#16410)
  chore: Changes the DatabaseSelector to use the new Select component (apache#16334)
  chore: Displays the dataset description in a tooltip in the datasets list (apache#16392)
  fix(pylint): Fix master (apache#16405)
  chore(pylint): Enable useless-suppression check (apache#16388)
  feat: Add extraVolumes and extraVolumeMounts to all main containers (apache#16361)
  initial commit (apache#16366)
  fix: big number default date format (apache#16383)
  initial commit (apache#16380)
  fix: import dashboard w/o metadata (apache#16360)
  test: Functional RTL for email report modal II (apache#16148)
  fix: update table ID in query context on chart import (apache#16374)
  docs: document FLASK_APP_MUTATOR (apache#16286)
  feat: Add new dev commands to Makefile (apache#16327)
  fix: call external metadata endpoint with correct rison object (apache#16369)
  fix: Fix parsing onSaving reports toast when user hasn't saved chart (apache#16330)
  fix: columns/index rebuild (apache#16355)
  chore(viz): bump deckgl plugin to 0.4.11 (apache#16353)
  fix: Blank space in Change dataset modal without warning message (apache#16324)
  ...

# Conflicts:
#	superset/app.py
#	superset/models/dashboard.py
#	tests/integration_tests/charts/filter_sets/__init__.py
#	tests/integration_tests/charts/filter_sets/conftest.py
#	tests/integration_tests/charts/filter_sets/consts.py
#	tests/integration_tests/charts/filter_sets/create_api_tests.py
#	tests/integration_tests/charts/filter_sets/delete_api_tests.py
#	tests/integration_tests/charts/filter_sets/get_api_tests.py
#	tests/integration_tests/charts/filter_sets/update_api_tests.py
#	tests/integration_tests/charts/filter_sets/utils.py
#	tests/integration_tests/superset_test_config.py
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@pkdotson
initial commit (apache#16366)
54bc8f6
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@pkdotson
initial commit (apache#16366)
1d60191
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@junlincc junlincc Awaiting requested review from junlincc

@kgabryje kgabryje Awaiting requested review from kgabryje

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

@villebro villebro Awaiting requested review from villebro

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[time series table] Run button did not light up or show when change time series column settings
4 participants
@pkdotson @junlincc @rusackas @mistercrunch