fix: Pin snowflake-sqlalchemy to 1.2.4 #16515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielewood
changed the title
nytai
approved these changes
Aug 31, 2021
|
Thanks for the fix @danielewood ! As SqlAlchemy 1.4 has been out for a while and seems to be gaining momentum, we should start preparing for upgrading to 1.4 shortly. |
9 tasks
villebro
pushed a commit
that referenced
this pull request
Sep 6, 2021
* Pin snowflake-sqlalchemy to 1.2.4 * lint files (cherry picked from commit ad8336a)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* Pin snowflake-sqlalchemy to 1.2.4 * lint files
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* Pin snowflake-sqlalchemy to 1.2.4 * lint files
mistercrunch
added
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
snowflake-sqlalchemy 1.2.5 introduced breaking changes requiring sqlalchemy>=1.4.0. This PR pins the last working version of 1.2.4 until Superset migrates to sqlalchemy>=1.4.0 and updates the docs accordingly.
Reference: snowflakedb/snowflake-sqlalchemy#235
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION