-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dashboard standalone class not added when parameter set #16619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and reproduced bug + verified that the fix works. Thanks so much for this! One minor nit - I'm going to merge later today, but if you happen to have time to make the proposed change that would make my linting OCD happier 🙂
@@ -1912,6 +1914,7 @@ def dashboard( | |||
bootstrap_data=json.dumps( | |||
bootstrap_data, default=utils.pessimistic_json_iso_dttm_ser | |||
), | |||
standalone_mode=standalone_mode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: since standalone_mode
isn't being reused, I'd prefer to place it inline here, like
standalone_mode=ReservedUrlParameters.is_standalone_mode(),
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
@trepmag sorry for dropping the ball on this - I rebased to retrigger CI and will merge today if CI passes. |
Codecov Report
@@ Coverage Diff @@
## master #16619 +/- ##
==========================================
- Coverage 66.51% 66.34% -0.17%
==========================================
Files 1690 1690
Lines 64730 64731 +1
Branches 6656 6656
==========================================
- Hits 43054 42947 -107
- Misses 19977 20085 +108
Partials 1699 1699
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit 5134c63)
…16619) Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
…16619) Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
SUMMARY
When the
standalone
url parameter is set the dashboard html body class should be set tostandalone
.This was integrated in issue #6811.