-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade babel #16885
chore: upgrade babel #16885
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16885 +/- ##
==========================================
+ Coverage 76.92% 76.95% +0.02%
==========================================
Files 1030 1030
Lines 55023 55213 +190
Branches 7463 7546 +83
==========================================
+ Hits 42329 42491 +162
- Misses 12441 12466 +25
- Partials 253 256 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This needs a rebase (I noticed when looking at the failed frontend tests that this was cut prior to bumping Node to v. 16) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works well in testing, thanks so much for this work! 💯
* upgrade babel versions * upgrade babel eslint parser * fix test
* upgrade babel versions * upgrade babel eslint parser * fix test
SUMMARY
Upgrades versions of all babel libraries.
TESTING INSTRUCTIONS
This affects the entire js build, so technically if we want to be super rigorous we need to test all code paths 🤢 .
But the version bumps are all minor, so as long as CI is green there should be no special QA required.
ADDITIONAL INFORMATION