fix: rolling and cum operator on multiple series #16945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16945 +/- ##
==========================================
- Coverage 76.97% 76.91% -0.06%
==========================================
Files 1022 1027 +5
Lines 54903 55089 +186
Branches 7485 7485
==========================================
+ Hits 42262 42374 +112
- Misses 12393 12467 +74
Partials 248 248
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
reviewed
Oct 4, 2021
Sure, I will add such UT. |
zhaoyongjie
commented
Oct 6, 2021
Comment on lines
+581
to
+586
| df_cum = getattr(df_cum, operation)() | ||
| agg_in_pivot_df = df.columns.get_level_values(0).drop_duplicates().to_list() | ||
| agg: Dict[str, Dict[str, Any]] = {col: {} for col in agg_in_pivot_df} | ||
| df_cum.columns = [ | ||
| _flatten_column_after_pivot(col, agg) for col in df_cum.columns | ||
| ] |
There was a problem hiding this comment.
I will create a separate PR for refactoring _flatten_column_after_pivot
zhaoyongjie
commented
Oct 6, 2021
Comment on lines
+422
to
+426
| agg_in_pivot_df = df.columns.get_level_values(0).drop_duplicates().to_list() | ||
| agg: Dict[str, Dict[str, Any]] = {col: {} for col in agg_in_pivot_df} | ||
| df_rolling.columns = [ | ||
| _flatten_column_after_pivot(col, agg) for col in df_rolling.columns | ||
| ] |
There was a problem hiding this comment.
I will create a separate PR for refactoring _flatten_column_after_pivot
villebro
approved these changes
Oct 7, 2021
eschutho
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 27, 2021
* fix: rolling and cum operator on multiple series * add UT * updates (cherry picked from commit fd84614)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* fix: rolling and cum operator on multiple series * add UT * updates
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* fix: rolling and cum operator on multiple series * add UT * updates
mistercrunch
added
🍒 1.4.0
🍒 1.4.1
🍒 1.4.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently,
Rolling Windowcalculation results are incorrect on multiple series.Frontend codes at: apache-superset/superset-ui#1386
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
Before
TESTING INSTRUCTIONS
birth_namesdatasettime-serieschartyear1970 - 2000sum__numgendersum22ADDITIONAL INFORMATION