Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto refresh interval won't be updated #17112

Merged
merged 2 commits into from
Oct 22, 2021
Merged

fix: auto refresh interval won't be updated #17112

merged 2 commits into from
Oct 22, 2021

Conversation

yougyoung94
Copy link
Contributor

@yougyoung94 yougyoung94 commented Oct 14, 2021 •
edited
Loading

SUMMARY

Fixes #17107
#17107

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2021-10-14.at.12.07.54.PM.mov

After:

Screen.Recording.2021-10-14.at.5.58.59.PM.mov

TESTING INSTRUCTIONS

  1. Apply changes to superset-frontend/src/dashboard/components/Header/index.jsx
  2. Build image and update docker-compose-non-dev.yml
  3. Run docker-compose -f docker-compose-non-dev.yml up

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 14, 2021 •
edited
Loading

Codecov Report

Merging #17112 (64dc493) into master (4c708af) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17112      +/-   ##
==========================================
- Coverage   76.91%   76.91%   -0.01%     
==========================================
  Files        1039     1039              
  Lines       55568    55572       +4     
  Branches     7570     7571       +1     
==========================================
+ Hits        42742    42744       +2     
- Misses      12576    12578       +2     
  Partials      250      250
Flag Coverage Δ
javascript 70.93% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/dashboard/components/Header/index.jsx 68.30% <50.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c708af...64dc493. Read the comment docs.

@villebro villebro self-requested a review October 14, 2021 18:32
@geido geido closed this Oct 15, 2021
@geido geido reopened this Oct 15, 2021
@geido
Copy link
Member

geido commented Oct 15, 2021

I am restarting the CI. I will spin up a test env as soon as the CI passes. Thanks for the contribution!!

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 15, 2021
@yougyoung94
Copy link
Contributor Author

@geido Thank you so much:):)

yougyoung94
yougyoung94 commented Oct 15, 2021
View reviewed changes
superset-frontend/src/dashboard/containers/DashboardPage.tsx Outdated
isDashboardHydrated.current = true;
dispatch(hydrateDashboard(dashboard, charts));
}
useEffect(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this part referring to this part

@geido
Copy link
Member

geido commented Oct 20, 2021

Still failing. Let me try to restart it for you @yougyoung94

@geido geido closed this Oct 20, 2021
@geido geido reopened this Oct 20, 2021
@geido
Copy link
Member

geido commented Oct 21, 2021 •
edited
Loading

@yougyoung94 There's still the same Cypress test failing. It might be worth looking into it. I don't see how it is related to your changes but it might be at this point.

@yougyoung94
Copy link
Contributor Author

@geido I discarded changes that are not critical to fix the issue and now it passed all the tests!
I will look into why the test failed previously... 🤔
But I think you can now merge this:):) 🙏

@geido
Copy link
Member

geido commented Oct 21, 2021

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://54.191.80.9:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido self-requested a review October 22, 2021 09:13
geido
geido approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix and keep them coming :)

@geido geido merged commit 35cbcc4 into apache:master Oct 22, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@villebro villebro Awaiting requested review from villebro

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto refresh interval won't be updated
3 participants
@yougyoung94 @geido @mistercrunch