Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moves the datasource components to the components folder #17130

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Moves the datasource components to the components folder. These components are used in the Dataset list and Explore.

This work is part of SIP-61

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #17130 (3c748a2) into master (e055e59) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17130   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files        1031     1032    +1     
  Lines       55229    55231    +2     
  Branches     7516     7516           
=======================================
+ Hits        42496    42498    +2     
  Misses      12482    12482           
  Partials      251      251           
Flag Coverage Δ
javascript 70.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/components/Datasource/DatasourceEditor.jsx 71.91% <ø> (ø)
...tend/src/components/Datasource/DatasourceModal.tsx 75.38% <ø> (ø)
...re/components/controls/DatasourceControl/index.jsx 79.06% <ø> (ø)
...rc/components/Datasource/ChangeDatasourceModal.tsx 86.36% <100.00%> (ø)
...erset-frontend/src/components/Datasource/index.tsx 100.00% <100.00%> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 66.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e055e59...3c748a2. Read the comment docs.

@pkdotson
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://34.216.137.132:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit e32acd2 into apache:master Oct 20, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants