Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: title case in menus #17135

Merged
merged 1 commit into from
Nov 11, 2021
Merged

fix: title case in menus #17135

merged 1 commit into from
Nov 11, 2021

Conversation

mistercrunch
Copy link
Member

Let's stick to title case in the navbar. This tackles two entries that
have been triggering my OCD

Let's stick to title case in the navbar. This tackles two entries that
have been triggering my OCD
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #17135 (3ca3fd2) into master (e32a12f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17135   +/-   ##
=======================================
  Coverage   76.70%   76.71%           
=======================================
  Files        1031     1031           
  Lines       55155    55174   +19     
  Branches     7499     7499           
=======================================
+ Hits        42307    42324   +17     
- Misses      12596    12598    +2     
  Partials      252      252           
Flag Coverage Δ
mysql 81.93% <ø> (+<0.01%) ⬆️
postgres 81.94% <ø> (+<0.01%) ⬆️
python 82.02% <ø> (+<0.01%) ⬆️
sqlite 81.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/initialization/__init__.py 87.90% <ø> (ø)
superset/db_engine_specs/bigquery.py 84.75% <0.00%> (-1.22%) ⬇️
superset/views/base.py 75.00% <0.00%> (ø)
superset/connectors/sqla/models.py 85.61% <0.00%> (+0.01%) ⬆️
superset/config.py 91.47% <0.00%> (+0.02%) ⬆️
superset/views/core.py 76.94% <0.00%> (+0.03%) ⬆️
superset/views/database/views.py 88.46% <0.00%> (+0.04%) ⬆️
superset/connectors/base/models.py 88.25% <0.00%> (+0.11%) ⬆️
superset/utils/core.py 89.97% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32a12f...3ca3fd2. Read the comment docs.

Copy link
Contributor

@jayakrishnankk jayakrishnankk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 0257cf7 into apache:master Nov 11, 2021
@villebro villebro deleted the fix_case_in_menu branch November 11, 2021 09:17
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
Let's stick to title case in the navbar. This tackles two entries that
have been triggering my OCD
@rusackas
Copy link
Member

I'm all for consistency, so this was good for a while. Just noting here that we should follow the capitalization guidelines and convert basically all of these to sentence case. This came up on another PR and we'll probably steer toward that change there.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants