-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: title case in menus #17135
fix: title case in menus #17135
Conversation
Let's stick to title case in the navbar. This tackles two entries that have been triggering my OCD
Codecov Report
@@ Coverage Diff @@
## master #17135 +/- ##
=======================================
Coverage 76.70% 76.71%
=======================================
Files 1031 1031
Lines 55155 55174 +19
Branches 7499 7499
=======================================
+ Hits 42307 42324 +17
- Misses 12596 12598 +2
Partials 252 252
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's stick to title case in the navbar. This tackles two entries that have been triggering my OCD
I'm all for consistency, so this was good for a while. Just noting here that we should follow the capitalization guidelines and convert basically all of these to sentence case. This came up on another PR and we'll probably steer toward that change there. |
Let's stick to title case in the navbar. This tackles two entries that
have been triggering my OCD