Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preventing sql lab None limit value #17155

Merged
merged 4 commits into from
Oct 20, 2021
Merged

Conversation

amitmiran137
Copy link
Member

@amitmiran137 amitmiran137 commented Oct 19, 2021

SUMMARY

closes #17138
fix issue raised in #17138
preventing a None value in the increased_limit been past into the SQL limit expression building part

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #17155 (7a5fdd3) into master (4cc095c) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17155      +/-   ##
==========================================
- Coverage   76.91%   76.83%   -0.08%     
==========================================
  Files        1038     1038              
  Lines       55557    55561       +4     
  Branches     7567     7567              
==========================================
- Hits        42731    42691      -40     
- Misses      12576    12620      +44     
  Partials      250      250              
Flag Coverage Δ
hive 81.46% <100.00%> (+<0.01%) ⬆️
javascript 70.93% <ø> (ø)
mysql 81.91% <100.00%> (+<0.01%) ⬆️
postgres 81.92% <100.00%> (+<0.01%) ⬆️
presto ?
python 82.27% <100.00%> (-0.15%) ⬇️
sqlite 81.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_lab.py 80.85% <100.00%> (+0.30%) ⬆️
superset/db_engine_specs/presto.py 84.30% <0.00%> (-6.07%) ⬇️
superset/connectors/sqla/models.py 85.91% <0.00%> (-1.41%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc095c...7a5fdd3. Read the comment docs.

@eschutho
Copy link
Member

Thanks @amitmiran137. This looks like it will fix the issue. Can you add a test to confirm that it will not add a limit for the use case you updated? And to prevent regressions. 🙏

@eschutho
Copy link
Member

@hughhhh for review since you’re also looking into this error.

@hughhhh hughhhh self-requested a review October 20, 2021 17:47
@amitmiran137 amitmiran137 merged commit 029ed90 into master Oct 20, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* fix: preventing sql lab None limit value

* test: create a test for the fix

* pylint (apache#17172)

* add test (apache#17173)

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the amitmiran137-patch-5 branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants