-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preventing sql lab None limit value #17155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17155 +/- ##
==========================================
- Coverage 76.91% 76.83% -0.08%
==========================================
Files 1038 1038
Lines 55557 55561 +4
Branches 7567 7567
==========================================
- Hits 42731 42691 -40
- Misses 12576 12620 +44
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks @amitmiran137. This looks like it will fix the issue. Can you add a test to confirm that it will not add a limit for the use case you updated? And to prevent regressions. 🙏 |
@hughhhh for review since you’re also looking into this error. |
* fix: preventing sql lab None limit value * test: create a test for the fix * pylint (apache#17172) * add test (apache#17173) Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
SUMMARY
closes #17138
fix issue raised in #17138
preventing a None value in the increased_limit been past into the SQL limit expression building part
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION