fix: avoid filters containing null value

[zhaoyongjie]

SUMMARY

related PR: #16936
closed: #16803

Avoid filters getting null values. User should add IS NOT NULL or IS NULL operator to handle Empty value in SQL

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: [explore][filter] NOT EQUALS NULL doesn't allow to SAVE #16803
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #17168 (a66e162) into master (d38e686) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head a66e162 differs from pull request most recent head 4b00577. Consider uploading reports for the commit 4b00577 to get more accurate results

@@            Coverage Diff             @@
##           master   #17168      +/-   ##
==========================================
- Coverage   76.91%   76.69%   -0.22%     
==========================================
  Files        1038     1039       +1     
  Lines       55557    55561       +4     
  Branches     7567     7567              
==========================================
- Hits        42729    42614     -115     
- Misses      12578    12697     +119     
  Partials      250      250              

Flag	Coverage Δ
hive	?
mysql	81.91% <100.00%> (+<0.01%)	⬆️
postgres	81.92% <100.00%> (+<0.01%)	⬆️
presto	?
python	82.00% <100.00%> (-0.42%)	⬇️
sqlite	81.59% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...end/src/components/Datasource/DatasourceEditor.jsx	71.91% <ø> (ø)
...tend/src/components/Datasource/DatasourceModal.tsx	75.38% <ø> (ø)
...re/components/controls/DatasourceControl/index.jsx	79.06% <ø> (ø)
superset/views/core.py	76.94% <ø> (ø)
...rc/components/Datasource/ChangeDatasourceModal.tsx	86.36% <100.00%> (ø)
...erset-frontend/src/components/Datasource/index.tsx	100.00% <100.00%> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx	66.29% <100.00%> (ø)
superset/connectors/base/models.py	88.25% <100.00%> (ø)
superset/connectors/druid/models.py	82.99% <100.00%> (ø)
superset/connectors/sqla/models.py	85.71% <100.00%> (-1.61%)	⬇️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38e686...4b00577. Read the comment docs.

[pkdotson]

/testenv up

[github-actions]

@pkdotson Ephemeral environment spinning up at http://54.244.176.33:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[pkdotson]

Tested in eph env and LGTM! I'll close my pr since it's no longer need. Would be nice to get @villebro checkmark as well!

[villebro]

@zhaoyongjie does the filter box use this same endpoint? IIRC, the filter box select works with null values (the native filter one does, too, but it uses the chart data endpoint for this so won't be affected). If this doesn't affect the filter box then LGTM, otherwise we may need to add an additional param to the endpoint path to toggle between allowing/disallowing nulls and calling it without nulls only on the adhoc filter request.

[zhaoyongjie]

@zhaoyongjie does the filter box use this same endpoint? IIRC, the filter box select works with null values (the native filter one does, too, but it uses the chart data endpoint for this so won't be affected). If this doesn't affect the filter box then LGTM, otherwise we may need to add an additional param to the endpoint path to toggle between allowing/disallowing nulls and calling it without nulls only on the adhoc filter request.

Good point! currently(after this PR), changed original behavior.

For example, there is a table:

SELECT 'foo' as foo 
UNION 
SELECT 'bar'
UNION
SELECT NULL
-----------------------------
foo
NULL
bar
foo

We call the filter endpoint before, the response was

[None, 'bar', 'foo']

and now, the response is

['bar', 'foo']

but the None value is doesn't fit SQL where clause. for instance:

SELECT col1
FROM tbl
WHERE col1 in (NULL)

So, I think we can change old behavior safely. might be I have not considered it well, What do you think about it?

[villebro]

@zhaoyongjie let me test this quickly, too!

[villebro]

Code LGTM + Tested to work as expected; the new flow of not making the NULL value available in the adhoc filter select makes more sense as there is the IS NULL option, and the filter box null value dropdown still works like before.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.