fix(sqla): convert prequery results to native python types #17195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When limiting a query with top n series on a db that doesn't support subqueries (e.g. Druid), numeric values are sometimes returned as
numpy
types. For instance, integer values are returned asnumpy.int64
instead ofint
. If the groupby column type is set to String type, despite the expression returning a numeric value, this causes the following SQLAlchemy compilation error:This is due to SQLAlchemy attempting to perform a string replacement operation on the numeric value to escape hyphens during query compilation. However, by ensuring that the value is first converted into its native Python equivalent (
np.inp64
toint
), SQLAlchemy is able to ignore the incorrect target type (in this caseString
), and is able to successfully compile the query:TESTING INSTRUCTIONS
ADDITIONAL INFORMATION