Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Position of the tools of the Tabs component in Edit Dashboard #17221

Merged
merged 1 commit into from
Oct 26, 2021
Merged

fix(Dashboard): Position of the tools of the Tabs component in Edit Dashboard #17221

merged 1 commit into from
Oct 26, 2021

Conversation

geido
Copy link
Member

@geido geido commented Oct 25, 2021

SUMMARY

This PR fixes the positions of the tools of the tabs when editing a Dashboard.

BEFORE

Fixes #17156

AFTER

untitled.dashb.1.mp4

TESTING INSTRUCTIONS

  1. Edit a Dashboard
  2. Hover a Tabs component
  3. Observe the position of the floating left tools

ADDITIONAL INFORMATION

@pkdotson
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://52.43.10.229:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #17221 (4883017) into master (08aab3b) will not change coverage.
The diff coverage is n/a.

❗ Current head 4883017 differs from pull request most recent head f02762c. Consider uploading reports for the commit f02762c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17221   +/-   ##
=======================================
  Coverage   76.95%   76.95%           
=======================================
  Files        1038     1038           
  Lines       55597    55597           
  Branches     7585     7585           
=======================================
  Hits        42787    42787           
  Misses      12560    12560           
  Partials      250      250           
Flag Coverage Δ
javascript 71.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/components/DashboardBuilder/DashboardBuilder.tsx 90.17% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08aab3b...f02762c. Read the comment docs.

@pkdotson
Copy link
Member

LGTM! Thanks for the fix!

@geido geido merged commit 5f8f67e into apache:master Oct 26, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard edit] tool menu of row is over-lapping with other tool menu of components
3 participants