Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated connection string for Firebolt #17242

Merged
merged 17 commits into from
Oct 29, 2021

Conversation

raghavSharmaCode
Copy link
Contributor

fix: Updated connection string for Firebolt

@raghavSharmaCode
Copy link
Contributor Author

Hi Team!
Can someone take a look at this PR and review it for merging ?

@raghavSharmaCode
Copy link
Contributor Author

@villebro please guide. Thanks!

@villebro
Copy link
Member

Sure @raghavSharmaSigmoid! Can you rebase the PR? it seems there are multiple conflicts here

@raghavSharmaCode
Copy link
Contributor Author

Sure. Thanks for the reply.

@pull-request-size pull-request-size bot added size/S and removed size/L labels Oct 29, 2021
@raghavSharmaCode raghavSharmaCode changed the title Firebolt integration fix: Updated connection string for Firebolt Oct 29, 2021
@raghavSharmaCode
Copy link
Contributor Author

@villebro , all checks have passed. Can you merge the PR ?

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@villebro villebro merged commit 0a660a1 into apache:master Oct 29, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* New branch from superset for integration with firebolt sqlalchemy adapter

* Added db_engine_spec file for Firebolt

* Removed firebolt code from superset repo

* Deleted virtual env commit

* Adding time grain changes to firebolt.py

* Updated README.md

Added steps to install and run Superset with Firebolt SQLAlchemy Adapter

* Update README.md

Reduced installation steps. Using PyPi installation for adapter now

* Revert "Update README.md"

This reverts commit 5ed17c7.

* Revert "Updated README.md"

This reverts commit 45c5072.

* added epoch methods, added test cases for firebolt db engine spec and edited setup.py

* Added license to files

* Added documentation for Firebolt-SQLAlchemy

* Removed trailing whitespace

* Updated connection string for Firebolt

Co-authored-by: apurva-sigmoid <89530372+apurva-sigmoid@users.noreply.github.com>
Co-authored-by: Apurva Anand <aapurva@sigmoidanalytics.com>
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants