Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump superset-ui to 0.18.17 #17270

Merged
merged 1 commit into from
Oct 28, 2021
Merged

chore: bump superset-ui to 0.18.17 #17270

merged 1 commit into from
Oct 28, 2021

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Oct 28, 2021 •
edited
Loading

SUMMARY

As titled. Rebuilt superset-frontend/package-lock.json by running npm install.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

john-bodley
john-bodley commented Oct 28, 2021
View reviewed changes
superset-frontend/package.json
@@ -68,35 +68,35 @@
"@emotion/cache": "^11.4.0",
"@emotion/react": "^11.4.1",
"@emotion/styled": "^11.3.0",
"@superset-ui/chart-controls": "^0.18.16",
"@superset-ui/core": "^0.18.15",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why @superset-ui/core wasn't bumped to ^0.18.16 previously.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 0.18.16 release probably didn't touch core, therefore it was excluded from that version (screenshot from npm release page):
image

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #17270 (d070308) into master (37909aa) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head d070308 differs from pull request most recent head 1d67cde. Consider uploading reports for the commit 1d67cde to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17270      +/-   ##
==========================================
- Coverage   77.02%   77.02%   -0.01%     
==========================================
  Files        1037     1037              
  Lines       55629    55629              
  Branches     7594     7594              
==========================================
- Hits        42849    42848       -1     
- Misses      12530    12531       +1     
  Partials      250      250
Flag Coverage Δ
javascript 71.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 87.13% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37909aa...1d67cde. Read the comment docs.

graceguo-supercat
graceguo-supercat approved these changes Oct 28, 2021
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit ce558e0 into apache:master Oct 28, 2021
@john-bodley john-bodley deleted the john-bodley--bump-superset-ui branch October 28, 2021 21:45
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@john-bodley @AAfghahi
chore: bump superset-ui to 0.18.17 (#17270)
15f0f60 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro left review comments

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

@zhaoyongjie zhaoyongjie Awaiting requested review from zhaoyongjie

@etr2460 etr2460 Awaiting requested review from etr2460

@ktmud ktmud Awaiting requested review from ktmud

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@john-bodley @graceguo-supercat @villebro @mistercrunch