Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add native filter part2 #17283

Merged
merged 4 commits into from
Nov 1, 2021

Conversation

jinghua-qa
Copy link
Member

SUMMARY

Add Native filter E2E test part2:
1, User can delete a native filter
2,User can cancel changes in native filter
3,User can cancel creating a new filter

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Oct 29, 2021
@jinghua-qa jinghua-qa changed the title add native filter part2 test:add native filter part2 Oct 29, 2021
@jinghua-qa jinghua-qa closed this Oct 29, 2021
@jinghua-qa jinghua-qa reopened this Oct 29, 2021
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #17283 (e9d0707) into master (9ef9adf) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17283      +/-   ##
==========================================
+ Coverage   77.02%   77.07%   +0.05%     
==========================================
  Files        1037     1037              
  Lines       55629    55644      +15     
  Branches     7594     7603       +9     
==========================================
+ Hits        42849    42889      +40     
+ Misses      12530    12505      -25     
  Partials      250      250              
Flag Coverage Δ
javascript 71.25% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/controls/MetricControl/MetricsControl.jsx 38.18% <0.00%> (-3.88%) ⬇️
...e/components/controls/MetricControl/AdhocMetric.js 97.33% <0.00%> (+0.07%) ⬆️
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx 61.76% <0.00%> (+19.88%) ⬆️
...s/controls/MetricControl/MetricDefinitionValue.jsx 100.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef9adf...e9d0707. Read the comment docs.

@jinghua-qa jinghua-qa changed the title test:add native filter part2 test: add native filter part2 Oct 29, 2021
@jinghua-qa jinghua-qa closed this Oct 29, 2021
@jinghua-qa jinghua-qa reopened this Oct 29, 2021
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit abf24bb into apache:master Nov 1, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* add native filter part2

* fix lint

* remove unused code

* fix lint after modified
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:QA Preset QA team size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants